Skip to content

Remove postgres_latest as image tag #2045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 31, 2025
Merged

Remove postgres_latest as image tag #2045

merged 4 commits into from
Jul 31, 2025

Conversation

@MonkeyCanCode
Copy link
Contributor

@MonkeyCanCode MonkeyCanCode commented Jul 14, 2025 •
edited
Loading

Based from both #2036 and #1957, we will be removing postgres_latest as image tag and use latest as image tag instead.

@github-project-automation github-project-automation bot moved this to PRs In Progress in Basic Kanban Board Jul 14, 2025
adutra
adutra reviewed Jul 14, 2025
View reviewed changes
adutra
adutra previously approved these changes Jul 15, 2025
View reviewed changes
Copy link
Contributor

@adutra adutra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MonkeyCanCode!

@github-project-automation github-project-automation bot moved this from PRs In Progress to Ready to merge in Basic Kanban Board Jul 15, 2025
@snazy
Copy link
Member

snazy commented Jul 15, 2025

Wait a sec ...

@snazy
Copy link
Member

snazy commented Jul 15, 2025

Nope, all good. I see you removed the -SNAPSHOT reference.

For posterity: as an Apache project we have to direct users to official releases, never to snapshots, nightlies and similar.
Since you're referring to the Docker repo for official releases, that's fine.

@MonkeyCanCode
Copy link
Contributor Author

MonkeyCanCode commented Jul 15, 2025

Nope, all good. I see you removed the -SNAPSHOT reference.

For posterity: as an Apache project we have to direct users to official releases, never to snapshots, nightlies and similar.
Since you're referring to the Docker repo for official releases, that's fine.

Oh, that is good to know. In that case, we will need to change the value files in the helm right? That is referring to the snapshot one @adutra

@adutra
Copy link
Contributor

adutra commented Jul 15, 2025

Oh, that is good to know. In that case, we will need to change the value files in the helm right? That is referring to the snapshot one @adutra

I guess you are right... we should use tag: latest instead of tag: "1.1.0-incubating-SNAPSHOT".

I don't know why #1957 included a -SNAPSHOT tag in the chart... oddly enough, the tag exists, but it doesn't align with our recent discussions about nightly images in #1593. @flyrain do you remember the rationale? I think we need to revisit this, imho the safest choice is to go with latest.

@adutra
Copy link
Contributor

adutra commented Jul 16, 2025

OK I finally found the discussion I had with @flyrain about image tags:

#1944 (comment)

Yufei was advocating for specific tags in case users want to downgrade the helm chart.

I confess I'm now thinking that it's too much hassle keeping specific Docker image versions in the Helm chart compared to the (limited) benefits. Besides, if we move the Helm chart out of this repo, as it was proposed, then it probably doesn't make sense at all to use specific versions in image.tag.

adutra
adutra reviewed Jul 16, 2025
View reviewed changes
helm/polaris/values.yaml
pullPolicy: IfNotPresent
# -- The image tag.
tag: "1.1.0-incubating-SNAPSHOT"
tag: "latest"
Copy link
Contributor

@adutra adutra Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this change, but let's wait for @flyrain to chime in.

Copy link
Contributor

@flyrain flyrain Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for the change, since we are moving helm chart out of the main repo.

@adutra
Copy link
Contributor

adutra commented Jul 23, 2025

@flyrain please have a look whenever you have time.

@MonkeyCanCode MonkeyCanCode merged commit eefe572 into apache:main Jul 31, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from Ready to merge to Done in Basic Kanban Board Jul 31, 2025
snazy added a commit to snazy/polaris that referenced this pull request Nov 20, 2025
@snazy @XN137
@renovate-bot @MonkeyCanCode @tmater @adutra
Dremio merge 2025 08 01 12 58 (apache#98)
0266ba7 
* Simplify BaseMetaStoreManager.extractStorageConfiguration (apache#2194)

as a static helper method its strongly preferable to not depend on
the full `PolarisCallContext` if not necessary.

* Remove PolarisCallContext from TreeMapMetaStore (apache#2195)

* remove PolarisCallContext from TreeMapMetaStore methods

* reset diagnosticServices in TreeMapMetaStore

* simplify ensure methods

* Remove getCurrentContext from InMemoryStorageIntegration (apache#2201)

* Remove getCurrentContext from JWTBroker (apache#2202)

* fix(deps): update dependency boto3 to v1.39.17 (apache#2211)

* fix(deps): update dependency org.apache.commons:commons-compress to v1.28.0 (apache#2212)

* Enable python client debug flag (apache#2154)

* Enable python client debug flag

* Move debug msg to stderr and move debug enable after option parsing

* Remove postgres_latest as image tag (apache#2045)

* Remove postgres_latest as image tag

* Change image tag to latest for getting started examples

* Change image tag to latest from helm

* fix(deps): update dependency io.smallrye.common:smallrye-common-annotation to v2.13.8 (apache#2222)

* Remove CallContextResolver (apache#2215)

it seems like these were unused leftovers from previous changes

* Replace CommitFailedException with CommitConflictException (apache#2198)

* Replace CommitFailedException with CommitConflictException

In some cases, we were using CommitFailedException to represent commit
conflicts, which returns the correct 409 response but is tied to Iceberg.

However, some of these conflicts originate from Polaris, making
CommitConflictException a more appropriate and accurate choice.

This change updates those instances to improve clarity and exception
handling semantics.

Resolves apache#2168

* JDBC: Include error code + SQL state in exception messages (apache#2220)

* fix(deps): update dependency boto3 to v1.40.0 (apache#2225)

* chore(deps): update actions/stale digest to 8f717f0 (apache#2224)

* Fix Awaitility build configuration (apache#2232)

* Fix compilation warnings in AzureCredentialStorageIntegrationTest (apache#2231)

* Remove CallContext.CURRENT_CONTEXT (apache#2203)

the last callers of `CallContext.getCurrentContext` had been
removed in the following commits:

- 756e535
- e7eb59f
- 4d94745

thus we can now remove the `CURRENT_CONTEXT` threadlocal and all
associated methods.

* NoSQL: adoptions & cosmetics

* Last merged commit 0449d9b

---------

Co-authored-by: Christopher Lambert <xn137@gmx.de>
Co-authored-by: Mend Renovate <bot@renovateapp.com>
Co-authored-by: Yong Zheng <yongzheng0809@gmail.com>
Co-authored-by: Tamas Mate <50709850+tmater@users.noreply.github.com>
Co-authored-by: Alexandre Dutra <adutra@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flyrain flyrain flyrain left review comments

@adutra adutra adutra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MonkeyCanCode @snazy @adutra @flyrain