Perform force repair when polaris not found #2313
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With change in #2049, we are not making polaris as a package and remove dependency on the the top level
polarisbash script (still useful ATM until we start publishing python CLI which is being asked in #2042). However, this does bring one non-backward compatible change where if the venv used by polaris was created long before, it can be a breaking change #2293. To fix this problem, this PR added a check ifpolariscommand existed. If missing (which indicated older venv), it will then use a sub-process to perform a force repair then loaded the new venv and continue the workflow.Here is how to reproduce this issue and how this PR fix this issue:
To reproduce this issue, I will setup an venv with older branch:
Now to reproduce the issue, i will switch to the main branch:
Now the issue is easily reproducible. With the current PR, user will then see the following: