-
Notifications
You must be signed in to change notification settings - Fork 332
Reproducible builds: ensure unix permissions are reproducible #2819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zip and tar files contain the unix file/directory permissions for the included zip/tar entries. The "default" values for those can differ depending on the platform those are built on. This change ensures `755` for directories and owner/group/other=read+write for files. The "executable" bit isn't forcefully set in case the archived file _is_ an executable.
Member
Author
|
Noticed that the binary jar files of 1.2.0-incubating-rc1 in the staging repo are different ( The reason was the "group write" POSIX permission bit as reported by vs The actual content (via |
13 tasks
dimas-b
approved these changes
Oct 15, 2025
singhpk234
approved these changes
Oct 16, 2025
snazy
added a commit
to snazy/polaris
that referenced
this pull request
Nov 20, 2025
* Update actions/stale digest to 65d1d48 (apache#2813) * Update dependency org.testcontainers:testcontainers-bom to v2 (apache#2814) * Site: Update community page / team (apache#2817) Update entries for Alex + Mike (committer --> PPMC member). * Site: fix typo of catalog federation configuration in command-line-interface.md (apache#2825) * Update docker.io/prom/prometheus Docker tag to v3.7.0 (apache#2820) * Update quay.io/keycloak/keycloak Docker tag to v26.4.1 (apache#2827) * Reproducible builds: ensure unix permissions are reproducible (apache#2819) Zip and tar files contain the unix file/directory permissions for the included zip/tar entries. The "default" values for those can differ depending on the platform those are built on. This change ensures `755` for directories and owner/group/other=read+write for files. The "executable" bit isn't forcefully set in case the archived file _is_ an executable. * Reproducible builds: use a fixed mtime for all entries in the source tarball (apache#2823) This change makes generated source-tarballs binary-comparable, so that locally built one (via `./gradlew sourceTarball`) should be exactly the same as a staged one. * NoSQL: adoptions * Last merged commit 0fdaa5a --------- Co-authored-by: Mend Renovate <bot@renovateapp.com> Co-authored-by: Nuoya Jiang <98131931+NuoyaJiang@users.noreply.github.com>
snazy
added a commit
to snazy/polaris
that referenced
this pull request
Nov 24, 2025
The PR apache#2819 accidentally _removed_ the executable POSIX file permission, assuming that not explicity setting the attributes via `filePermissions` retains the file-system 'x' permission. This change updates the logic to explicitly check the owner-executable bit and uses `755` or `644` respectively for each individual file in the archive.
snazy
added a commit
to snazy/polaris
that referenced
this pull request
Nov 24, 2025
The PR apache#2819 accidentally _removed_ the executable POSIX file permission, assuming that not explicity setting the attributes via `filePermissions` retains the file-system 'x' permission. This change updates the logic to explicitly check the owner-executable bit and uses `755` or `644` respectively for each individual file in the archive.
snazy
added a commit
that referenced
this pull request
Nov 24, 2025
The PR #2819 accidentally _removed_ the executable POSIX file permission, assuming that not explicity setting the attributes via `filePermissions` retains the file-system 'x' permission. This change updates the logic to explicitly check the owner-executable bit and uses `755` or `644` respectively for each individual file in the archive.
pingtimeout
pushed a commit
to pingtimeout/polaris
that referenced
this pull request
Nov 24, 2025
The PR apache#2819 accidentally _removed_ the executable POSIX file permission, assuming that not explicity setting the attributes via `filePermissions` retains the file-system 'x' permission. This change updates the logic to explicitly check the owner-executable bit and uses `755` or `644` respectively for each individual file in the archive.
pingtimeout
added a commit
that referenced
this pull request
Nov 24, 2025
The PR #2819 accidentally _removed_ the executable POSIX file permission, assuming that not explicity setting the attributes via `filePermissions` retains the file-system 'x' permission. This change updates the logic to explicitly check the owner-executable bit and uses `755` or `644` respectively for each individual file in the archive. Co-authored-by: Robert Stupp <snazy@snazy.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zip and tar files contain the unix file/directory permissions for the included zip/tar entries. The "default" values for those can differ depending on the platform those are built on. This change ensures
755for directories and owner/group/other=read+write for files. The "executable" bit isn't forcefully set in case the archived file is an executable.