Skip to content

Conversation

@CodingBangboo
Copy link
Contributor

What changes were proposed in this pull request?

Python CLI currently support configuring 2 types of connection for catalog federation

  • iceberg-rest for Rest Catalog
  • hadoop for Hadoop Catalog

However, the CLI page currently shows the wrong strings

--catalog-connection-type  The type of external catalog in [ICEBERG, HADOOP].

This PR fixes typo to avoid confusion when users try catalog federation through python CLI.

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

CHANGELOG.md

Copy link
Contributor

@HonahX HonahX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

--service-account (Only for GCS) The service account to use when connecting to GCS
--property A key/value pair such as: tag=value. Multiple can be provided by specifying this option more than once
--catalog-connection-type The type of external catalog in [ICEBERG, HADOOP].
--catalog-connection-type The type of external catalog in [iceberg-rest, hadoop].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! As discussed in #2761 (comment), we could also update the enum value name to be consistent, but let's do that in a follow-up!

@github-project-automation github-project-automation bot moved this from PRs In Progress to Ready to merge in Basic Kanban Board Oct 16, 2025
@flyrain
Copy link
Contributor

flyrain commented Oct 16, 2025

I was trying to fix it in #2798. Still thanks you very much for the fix! Let me also make #2798 ready for review.

@flyrain flyrain merged commit 0c9bbd3 into apache:main Oct 16, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from Ready to merge to Done in Basic Kanban Board Oct 16, 2025
@CodingBangboo CodingBangboo deleted the nuoya_fixed_typo_CLI branch October 20, 2025 21:30
snazy added a commit to snazy/polaris that referenced this pull request Nov 20, 2025
* Update actions/stale digest to 65d1d48 (apache#2813)

* Update dependency org.testcontainers:testcontainers-bom to v2 (apache#2814)

* Site: Update community page / team (apache#2817)

Update entries for Alex + Mike (committer --> PPMC member).

* Site: fix typo of catalog federation configuration in command-line-interface.md (apache#2825)

* Update docker.io/prom/prometheus Docker tag to v3.7.0 (apache#2820)

* Update quay.io/keycloak/keycloak Docker tag to v26.4.1 (apache#2827)

* Reproducible builds: ensure unix permissions are reproducible (apache#2819)

Zip and tar files contain the unix file/directory permissions for the included zip/tar entries. The "default" values for those can differ depending on the platform those are built on. This change ensures `755` for directories and owner/group/other=read+write for files. The "executable" bit isn't forcefully set in case the archived file _is_ an executable.

* Reproducible builds: use a fixed mtime for all entries in the source tarball (apache#2823)

This change makes generated source-tarballs binary-comparable, so that locally built one (via `./gradlew sourceTarball`) should be exactly the same as a staged one.

* NoSQL: adoptions

* Last merged commit 0fdaa5a

---------

Co-authored-by: Mend Renovate <bot@renovateapp.com>
Co-authored-by: Nuoya Jiang <98131931+NuoyaJiang@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants