Build warning fixes #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
reviewed
Aug 3, 2024
polaris-service/src/main/java/io/polaris/service/catalog/PolarisCatalogHandlerWrapper.java
Outdated
Show resolved
Hide resolved
| @@ -36,8 +36,7 @@ public class PolarisCatalogHelpers { | |||
| private PolarisCatalogHelpers() {} | |||
|
|
|||
| public static List<String> tableIdentifierToList(TableIdentifier identifier) { | |||
| List<String> fullList = new ArrayList<>(); | |||
| fullList.addAll(Arrays.asList(identifier.namespace().levels())); | |||
| List<String> fullList = new ArrayList<>(Arrays.asList(identifier.namespace().levels())); | |||
There was a problem hiding this comment.
(optional) I don't think returning a mutable list is a good idea. I would recommend using ImmutableList of Guava as much as possible.
| public static final String REQUEST_PATH_CATALOG_INSTANCE_KEY = "REQUEST_PATH_CATALOG_INSTANCE"; | ||
| String REQUEST_PATH_CATALOG_INSTANCE_KEY = "REQUEST_PATH_CATALOG_INSTANCE"; |
There was a problem hiding this comment.
Why is this no longer a constant?
There was a problem hiding this comment.
It still is: this is an interface so public static final is implicit.
|
(Reopening, was closed due to GH's "fix comment" confusion) |
snazy
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few build warnings. There is no functional change, and each commit can be reviewed separately.