Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failed AsyncioTest.test_send_failure and clean up tests #231

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

BewareMyPower
Copy link
Contributor

@BewareMyPower BewareMyPower commented Oct 30, 2024

After apache/pulsar#23291, which is included in Pulsar 4.0.0, when the tenant does not exist, the broker will respond with BrokerMetadataError, which is retryable.

Before that, the error code is AuthorizationError, which is not retryable so that create_producer will fail immediately.

This patch fixes the test_send_failure to assert the error is Timeout. Additional, separate some tests from pulsar_test.py:

  1. debug logger tests will affect other tests so that all tests will print debug logs
  2. running schema_test in pulsar_test might have unexpected failures like
Failed to create ConsumerImpl for persistent://public/default/my-python-pattern-consumer-3-partition-0: Failed to create steady_timer: kqueue: Too many open files [system:24]
Failed when subscribed to topic persistent://public/default/my-python-pattern-consumer-3 in TopicsConsumer. Error - ConnectError
Unable to create Consumer - [Muti Topics Consumer: TopicName - persistent://public/default/my-python-pattern-consumer.* - Subscription - my-pattern-consumer-sub] Error - ConnectError
Failed to retry lookup for get-partition-metadata-persistent://public/default/my-v2-topic-producer-consumer: Failed to create steady_timer: kqueue: Too many open files [system:24]
Error Checking/Getting Partition Metadata while Subscribing on persistent://public/default/my-v2-topic-producer-consumer -- ConnectError
Failed to retry lookup for get-partition-metadata-persistent://public/default/my-v2-topic-producer-consumer: Failed to create steady_timer: kqueue: Too many open files [system:24]
Error Checking/Getting Partition Metadata while Subscribing on persistent://public/default/my-v2-topic-producer-consumer -- ConnectError
Failed to retry lookup for get-partition-metadata-persistent://public/default/test_has_message_available_after_seek-1730263910.78957: Failed to create steady_timer: kqueue: Too many open files [system:24]
Error Checking/Getting Partition Metadata while creating producer on persistent://public/default/test_has_message_available_after_seek-1730263910.78957 -- ConnectError
Failed to retry lookup for get-partition-metadata-persistent://public/default/test_seek_latest_message_id-1730263910.789991: Failed to create steady_timer: kqueue: Too many open files [system:24]

@BewareMyPower BewareMyPower self-assigned this Oct 30, 2024
@BewareMyPower BewareMyPower added this to the 3.6.0 milestone Oct 30, 2024
@BewareMyPower
Copy link
Contributor Author

I think this is a breaking change that should be reverted in newer releases. But for now, let's pass the tests for now.

@lhotari
Copy link
Member

lhotari commented Oct 30, 2024

After apache/pulsar#23291, which is included in Pulsar 4.0.0, when the tenant does not exist, the broker will respond with BrokerMetadataError, which is retryable

@BewareMyPower Please report this as an issue. Could you also follow up with a PR?

@BewareMyPower
Copy link
Contributor Author

@lhotari See apache/pulsar#23530

@RobertIndie RobertIndie merged commit 7289522 into apache:main Oct 31, 2024
11 checks passed
@BewareMyPower BewareMyPower deleted the bewaremypower/fix-ci branch October 31, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants