[fix] [log] Do not print error log if tenant/namespace does not exist when calling get topic metadata #23291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot rerun-failure-checks |
Technoboy-
approved these changes
Sep 12, 2024
Demogorgon314
approved these changes
Sep 13, 2024
codelipenghui
approved these changes
Sep 16, 2024
…nant/namespace does not exist
…nant/namespace does not exist
…nant/namespace does not exist
…nant/namespace does not exist
poorbarcode
force-pushed
the
fix/correct_error_if_ns_not_exists
branch
from
426a731 to
3813b93
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23291 +/- ##
============================================
+ Coverage 73.57% 74.55% +0.97%
- Complexity 32624 33928 +1304
============================================
Files 1877 1934 +57
Lines 139502 145045 +5543
Branches 15299 15851 +552
============================================
+ Hits 102638 108135 +5497
+ Misses 28908 28628 -280
- Partials 7956 8282 +326
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 15, 2024
… when calling get topic metadata (apache#23291) (cherry picked from commit 5583102) (cherry picked from commit 3ec6eea)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 16, 2024
… when calling get topic metadata (apache#23291) (cherry picked from commit 5583102) (cherry picked from commit 3ec6eea)
This was referenced Oct 30, 2024
RobertIndie
pushed a commit
to apache/pulsar-client-python
that referenced
this pull request
Oct 31, 2024
After apache/pulsar#23291, which is included in Pulsar 4.0.0, when the tenant does not exist, the broker will respond with `BrokerMetadataError`, which is retryable. Before that, the error code is `AuthorizationError`, which is not retryable so that `create_producer` will fail immediately. This patch fixes the `test_send_failure` to assert the error is `Timeout`. Additional, separate some tests from `pulsar_test.py`: 1. debug logger tests will affect other tests so that all tests will print debug logs 2. running `schema_test` in `pulsar_test` might have unexpected failures like ``` Failed to create ConsumerImpl for persistent://public/default/my-python-pattern-consumer-3-partition-0: Failed to create steady_timer: kqueue: Too many open files [system:24] Failed when subscribed to topic persistent://public/default/my-python-pattern-consumer-3 in TopicsConsumer. Error - ConnectError Unable to create Consumer - [Muti Topics Consumer: TopicName - persistent://public/default/my-python-pattern-consumer.* - Subscription - my-pattern-consumer-sub] Error - ConnectError Failed to retry lookup for get-partition-metadata-persistent://public/default/my-v2-topic-producer-consumer: Failed to create steady_timer: kqueue: Too many open files [system:24] Error Checking/Getting Partition Metadata while Subscribing on persistent://public/default/my-v2-topic-producer-consumer -- ConnectError Failed to retry lookup for get-partition-metadata-persistent://public/default/my-v2-topic-producer-consumer: Failed to create steady_timer: kqueue: Too many open files [system:24] Error Checking/Getting Partition Metadata while Subscribing on persistent://public/default/my-v2-topic-producer-consumer -- ConnectError Failed to retry lookup for get-partition-metadata-persistent://public/default/test_has_message_available_after_seek-1730263910.78957: Failed to create steady_timer: kqueue: Too many open files [system:24] Error Checking/Getting Partition Metadata while creating producer on persistent://public/default/test_has_message_available_after_seek-1730263910.78957 -- ConnectError Failed to retry lookup for get-partition-metadata-persistent://public/default/test_seek_latest_message_id-1730263910.789991: Failed to create steady_timer: kqueue: Too many open files [system:24] ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation & Modifications
If users trying to use a tenant that does not exist, the broker should not print an
error-levellog.Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x