Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The new Docbot spams PRs with multiple comments #16046

Closed
lhotari opened this issue Jun 14, 2022 · 3 comments · Fixed by #16060
Closed

The new Docbot spams PRs with multiple comments #16046

lhotari opened this issue Jun 14, 2022 · 3 comments · Fixed by #16060
Labels
area/ci type/bug The PR fixed a bug or issue reported a bug

Comments

@lhotari
Copy link
Member

lhotari commented Jun 14, 2022

Describe the bug
The new Docbot (#15797) added in #16027 spams PRs with multiple comments.

To Reproduce
There's an example in #16045
https://github.com/apache/pulsar/actions/workflows/ci-documentbot.yml

Example jobs:
image
Logs:
https://github.com/apache/pulsar/runs/6874257583?check_suite_focus=true
https://github.com/apache/pulsar/runs/6874257484?check_suite_focus=true
https://github.com/apache/pulsar/runs/6874256005?check_suite_focus=true

Expected behavior
The docbot shouldn't spam users with the same nagging message multiple times on the same PR.

Additional context
You can find workflow runs in https://github.com/apache/pulsar/actions/workflows/ci-documentbot.yml .
The workflow has been disabled until the problem is solved.

@lhotari lhotari added type/bug The PR fixed a bug or issue reported a bug area/ci labels Jun 14, 2022
@lhotari
Copy link
Member Author

lhotari commented Jun 14, 2022

@maxsxu @Anonymitaet I have disabled the docbot until this problem has been addressed since it's also spamming users with GitHub notifications.

@lhotari
Copy link
Member Author

lhotari commented Jun 14, 2022

In https://github.com/apache/pulsar/blob/master/.github/workflows/ci-documentbot.yml
there should be config to limit the concurrency so that there's one build job handling events for a single PR at a time.

Adding this to the yaml will accomplish that:

concurrency:
  group: ${{ github.workflow }}-${{ github.ref }}

docs for concurrency: https://docs.github.com/en/actions/using-jobs/using-concurrency

@Anonymitaet
Copy link
Member

@lhotari thanks for your guidance and resource! @maxsxu is fixing this issue and will keep you updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants