[fix][workflow] Support concurrency group and reusable workflow files in docbot #16060
Conversation
Multi workflows can be triggered while opened then labeled instantly, This scenario will cause inconsistent state of action. Signed-off-by: Max Xu <maxs.xu@gmail.com>
|
btw. please also change |
There was a problem hiding this comment.
see #16060 (comment) . I think it makes sense to address it in the same PR.
Thanks for this great suggestion! Totally agree with this method. Just a detail: If we address it in the same PR, should we change the PR title? @lhotari |
yes that makes sense. |
maxsxu
changed the title
Signed-off-by: Max Xu <maxs.xu@gmail.com>
Anonymitaet
added
doc
| @@ -46,7 +50,7 @@ jobs: | |||
| go-version: 1.18 | |||
|
|
|||
| - name: Labeling | |||
| uses: apache/pulsar-test-infra/docbot@master | |||
| uses: ./docbot | |||
There was a problem hiding this comment.
Why we cannot use apache/pulsar-test-infra/docbot@master in this case like pulsarbot?
cc @maxsxu
There was a problem hiding this comment.
@tisonkun I've explained that in this comment: #16060 (comment)
There was a problem hiding this comment.
If we adopt docker container action as described in apache/pulsar-test-infra#58, we may need not to checkout the code as well as setup-go, just use the action itself ><
Fixes #16046
Motivation
Multiple workflows can be running concurrently while
labeledevent triggered instantly afteropenedevent before the docbot workflow is running.This scenario will cause an inconsistent state of action and confused results.
Modifications
Added
concurrencyconcurrency.groupmeans workflow using the same concurrency group will be pendingconcurrency.cancel-in-progresswill cancel any currently running job or workflow in the same concurrency group. This option can resolve the inconsistent state issue.Tests
The demo can be found at open-github#12
And the workflow status