Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][workflow] Support concurrency group and reusable workflow files in docbot #16060

Merged
merged 2 commits into from
Jun 15, 2022
Merged

[fix][workflow] Support concurrency group and reusable workflow files in docbot #16060

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25f3491
ci: fix concurrency running issue
maxsxu Jun 14, 2022
ccd6800
ci: support reusable workflow files
maxsxu Jun 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/ci-documentbot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ on:
- labeled
- unlabeled

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
label:
if: ${{ github.repository == 'apache/pulsar' }}
Expand All @@ -46,7 +50,7 @@ jobs:
go-version: 1.18

- name: Labeling
uses: apache/pulsar-test-infra/docbot@master
uses: ./docbot
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we cannot use apache/pulsar-test-infra/docbot@master in this case like pulsarbot?

cc @maxsxu

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tisonkun I've explained that in this comment: #16060 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we adopt docker container action as described in apache/pulsar-test-infra#58, we may need not to checkout the code as well as setup-go, just use the action itself ><

env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
LABEL_WATCH_LIST: 'doc,doc-required,doc-not-needed,doc-complete'
Expand Down