Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat][workflow] Upgrade to new version of documentation bot #16027

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

maxsxu
Copy link
Contributor

@maxsxu maxsxu commented Jun 13, 2022

Master Issue: #15797

Motivation

We have implemented the new documentation bot at apache/pulsar-test-infra#43.
Now we can apply it to our workflow.

Modifications

Replace the old action with the new version of documentation bot.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

Signed-off-by: Max Xu <maxs.xu@gmail.com>
@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Jun 13, 2022
@Anonymitaet Anonymitaet requested a review from urfreespace June 13, 2022 03:56
@Anonymitaet
Copy link
Member

/pulsarbot run-failure-checks

@Technoboy- Technoboy- added this to the 2.11.0 milestone Jun 13, 2022
@Anonymitaet Anonymitaet merged commit f1d6b32 into apache:master Jun 13, 2022
@maxsxu maxsxu deleted the feat/update-docbot branch June 13, 2022 07:48
@lhotari
Copy link
Member

lhotari commented Jun 13, 2022

This seems to break the jobs. Invalid repository 'apache/pulsar-test-infra/docbot'. Expected format {owner}/{repo}. is the error message. @maxsxu did you test that this change works?

Comment on lines +37 to +41
- name: Checkout action
uses: actions/checkout@v3
with:
repository: apache/pulsar-test-infra/docbot
ref: master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't make sense.

@lhotari
Copy link
Member

lhotari commented Jun 13, 2022

@Anonymitaet How was this tested? All jobs fail after this was merged.

michaeljmarshall pushed a commit that referenced this pull request Jun 13, 2022
Signed-off-by: Max Xu <maxs.xu@gmail.com>

This is a follow up change to #16027

<!--
### Contribution Checklist
  
  - PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.trs9rsex3xom)*. 

  - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
  
  - Each pull request should address only one issue, not mix up code from multiple issues.
  
  - Each commit in the pull request has a meaningful commit message

  - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.

**(The sections below can be removed for hotfixes of typos)**
-->

### Motivation

Wrong action repository path.

### Modifications

Update action repository path

### Verifying this change

- [ ] Make sure that the change passes the CI checks.

*(Please pick either of the following options)*

This change is a trivial rework / code cleanup without any test coverage.

*(or)*

This change is already covered by existing tests, such as *(please describe tests)*.

*(or)*

This change added tests and can be verified as follows:

*(example:)*
  - *Added integration tests for end-to-end deployment with large payloads (10MB)*
  - *Extended integration test for recovery after broker failure*

### Does this pull request potentially affect one of the following parts:

*If `yes` was chosen, please highlight the changes*

  - Dependencies (does it add or upgrade a dependency): (yes / no)
  - The public API: (yes / no)
  - The schema: (yes / no / don't know)
  - The default values of configurations: (yes / no)
  - The wire protocol: (yes / no)
  - The rest endpoints: (yes / no)
  - The admin cli options: (yes / no)
  - Anything that affects deployment: (yes / no / don't know)

### Documentation

Check the box below or label this PR directly.

Need to update docs? 

- [ ] `doc-required` 
(Your PR needs to update docs and you will update later)
  
- [ ] `doc-not-needed` 
(Please explain why)
  
- [ ] `doc` 
(Your PR contains doc changes)

- [ ] `doc-complete`
(Docs have been already added)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants