Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Pulsar Functions Runtime doesn't properly enable direct byte buffer access for Netty on Java 17+ #22909

Closed
3 tasks done
lhotari opened this issue Jun 14, 2024 · 0 comments · Fixed by #22910
Closed
3 tasks done
Assignees
Labels
type/bug The PR fixed a bug or issue reported a bug

Comments

@lhotari
Copy link
Member

lhotari commented Jun 14, 2024

Search before asking

  • I searched in the issues and found nothing similar.

Read release policy

  • I understand that unsupported versions don't get bug fixes. I will attempt to reproduce the issue on a supported version of Pulsar client and Pulsar broker.

Version

This applies to Pulsar 3.0.0 Pulsar Functions Kubernetes Runtime or Pulsar Functions Process Runtime.

Minimal reproduce step

enabling DEBUG log for a function will log something like this at DEBUG level:

i.n.u.i.PlatformDependent0 - direct buffer constructor: unavailable: Unable to make private java.nio.DirectByteBuffer(long,int) accessible: module java.base does not "opens java.nio" to unnamed module @49fc609f {}
i.n.u.i.PlatformDependent0 - jdk.internal.misc.Unsafe.allocateUninitializedArray(int): unavailable: class io.netty.util.internal.PlatformDependent0$7 cannot access class jdk.internal.misc.Unsafe (in module java.base) because module java.base does not export jdk.internal.misc to unnamed module @49fc609f {}
i.n.u.i.PlatformDependent0 - java.nio.DirectByteBuffer.<init>(long, {int,long}): unavailable {}

What did you expect to see?

Netty's direct byte buffer support should be enabled because of performance reasons.

What did you see instead?

It wasn't enabled.

Anything else?

Related to #15256

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@lhotari lhotari added the type/bug The PR fixed a bug or issue reported a bug label Jun 14, 2024
@lhotari lhotari self-assigned this Jun 14, 2024
@lhotari lhotari changed the title [Bug] Pulsar Functions Kubernetes Runtime doesn't properly enable direct byte buffer access for Netty on Java 17+ [Bug] Pulsar Functions Runtime doesn't properly enable direct byte buffer access for Netty on Java 17+ Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
1 participant