[fix][jdk17] Enable Netty and BookKeeper IO optimizations on jdk17 #15256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
requested review from
eolivelli,
dave2wave,
merlimat and
michaeljmarshall
michaeljmarshall
approved these changes
Apr 21, 2022
@nicoloboschi - a function instance connects to bookkeeper when running stateful functions. I don't know any helpful client internals to determine if we'd need to look closer, though. |
|
/pulsarbot rerun-failure-checks |
Demogorgon314
approved these changes
Apr 22, 2022
|
/pulsarbot rerun-failure-checks |
1 similar comment
|
/pulsarbot rerun-failure-checks |
nicoloboschi
added a commit
to datastax/pulsar
that referenced
this pull request
Jan 18, 2023
…pache#15256) (cherry picked from commit 2d12011)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Follow up of #14999.
Based on netty/netty#12265 and apache/bookkeeper#3234 it is better to open other modules.
Modifications
java.base/java.util.zipmodule for BookKeeperjava.base/jdk.internal.miscmodule for NettyNote that the functions worker will spawn the process without these optimizations. It could be useful in case the connector uses Netty. Very unlikely that the function uses BookKeeper. I can follow up the Netty ones in another pull (with a lower priority).
no-need-doc