-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][fn] Enable optimized Netty direct byte buffer support for Pulsar Function runtimes #22910
Merged
lhotari
merged 3 commits into
apache:master
from
lhotari:lh-enable-netty-directbytebuffer-for-functions
Jun 17, 2024
Merged
[fix][fn] Enable optimized Netty direct byte buffer support for Pulsar Function runtimes #22910
lhotari
merged 3 commits into
apache:master
from
lhotari:lh-enable-netty-directbytebuffer-for-functions
Jun 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
added
type/bug
The PR fixed a bug or issue reported a bug
area/function
release/3.3.1
release/3.0.6
release/3.2.4
labels
Jun 14, 2024
lhotari
requested review from
merlimat,
freeznet,
dlg99,
eolivelli,
cbornet,
nlu90 and
nicoloboschi
June 14, 2024 16:36
4 tasks
cbornet
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
eolivelli
approved these changes
Jun 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 21, 2024
…r Function runtimes (apache#22910) (cherry picked from commit f3d4d5a) (cherry picked from commit 20de952)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 24, 2024
…r Function runtimes (apache#22910) (cherry picked from commit f3d4d5a) (cherry picked from commit 20de952)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 25, 2024
…r Function runtimes (apache#22910) (cherry picked from commit f3d4d5a) (cherry picked from commit 20de952)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 1, 2024
…r Function runtimes (apache#22910) (cherry picked from commit f3d4d5a) (cherry picked from commit 20de952)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/function
cherry-picked/branch-3.0
cherry-picked/branch-3.2
cherry-picked/branch-3.3
doc-not-needed
Your PR changes do not impact docs
release/3.0.6
release/3.2.4
release/3.3.1
type/bug
The PR fixed a bug or issue reported a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22909
Motivation
Netty's optimized direct byte buffer support is needed for high performance. Currently these debug messages will get logged when Netty library gets initialized:
Another detail is that Pulsar uses com.scurrilous.circe.checksum.Crc32cIntChecksum class for checksum calculation. For optimized checksum calculation Pulsar attempts to load libcirce-checksum native library. When that isn't available, com.scurrilous.circe.checksum.Java9IntHash is used. That only works when "--add-opens java.base/java.util.zip=ALL-UNNAMED" is passed on the command line.
Modifications
Pass these parameters in the Java runtime command line:
remove
--add-opens java.base/sun.net=ALL-UNNAMED
added in #16423 since it's no longer needed after #22329Documentation
doc
doc-required
doc-not-needed
doc-complete