[ElasticSearch Sink] Correct @FieldDoc defaultValue for some fields #12697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…primaryFields,maxRetries,indexNumberOfReplicas,createIndexIfNeeded
codelipenghui
approved these changes
Nov 9, 2021
nlu90
approved these changes
Nov 10, 2021
|
/pulsarbot rerun-failure-checks |
|
/pulsarbot run-failure-checks |
eolivelli
approved these changes
Dec 2, 2021
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
…primaryFields,maxRetries,indexNumberOfReplicas,createIndexIfNeeded (apache#12697)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
FieldDoc#defaultValue() is wrong for these fields:
These fields are available from the REST API since you can see the configuration for a connector. If not set, the value for these fields is wrong and can be very noisy for troubleshooting operations
Modifications
Fixed default values for these fields.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
Need to update docs?
no-need-doc