Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ElasticSearch Sink] Correct @FieldDoc defaultValue for some fields #12697

Merged
merged 2 commits into from
Dec 2, 2021
Merged

[ElasticSearch Sink] Correct @FieldDoc defaultValue for some fields #12697

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cab9ae8
[ElasticSearch Sink] Correct @FieldDoc defaultValue for some fields: …
nicoloboschi Nov 9, 2021
d9f3967
Merge branch 'apache:master' into doc/essink-default-value
nicoloboschi Dec 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .../elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/ElasticSearchConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,14 +79,14 @@ public class ElasticSearchConfig implements Serializable {

@FieldDoc(
required = false,
defaultValue = "true",
defaultValue = "false",
help = "Create the index if it does not exist"
)
private boolean createIndexIfNeeded = false;

@FieldDoc(
required = false,
defaultValue = "1",
defaultValue = "0",
help = "The number of replicas of the index"
)
private int indexNumberOfReplicas = 0;
Expand All @@ -109,7 +109,7 @@ public class ElasticSearchConfig implements Serializable {

@FieldDoc(
required = false,
defaultValue = "-1",
defaultValue = "1",
help = "The maximum number of retries for elasticsearch requests. Use -1 to disable it."
)
private int maxRetries = 1;
Expand Down Expand Up @@ -216,7 +216,7 @@ public class ElasticSearchConfig implements Serializable {

@FieldDoc(
required = false,
defaultValue = "id",
defaultValue = "",
help = "The comma separated ordered list of field names used to build the Elasticsearch document _id from the record value. If this list is a singleton, the field is converted as a string. If this list has 2 or more fields, the generated _id is a string representation of a JSON array of the field values."
)
private String primaryFields = "";
Expand Down