remove unnecessary string operation #12719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gaozhangmin:Thanks for your contribution. For this PR, do we need to update docs? |
gaozhangmin
changed the title
|
@gaozhangmin:Thanks for providing doc info! |
github-actions
bot
added
doc-not-needed
|
/pulsarbot run-failure-checks |
hezhangjian
approved these changes
Nov 10, 2021
codelipenghui
approved these changes
Nov 10, 2021
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
RobertIndie
reviewed
Nov 11, 2021
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/BaseResource.java
Outdated
Show resolved
Hide resolved
gaozhangmin
force-pushed
the
redudant-string-operation
branch
from
db496b7 to
12d282d
Compare
RobertIndie
approved these changes
Nov 11, 2021
yuruguo
approved these changes
Nov 13, 2021
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Dec 20, 2021
(cherry picked from commit 4cf4b85)
gaoran10
added
the
type/cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some string operation is not necessary
Modifications
remove unnecessary string operation
Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doccode optimize
doc(If this PR contains doc changes)