remove unnecessary string operation (apache#12719)

eolivelli · Nov 29, 2021 · a31af46 · a31af46
1 parent ce902d0
commit a31af46
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 7 deletions.
diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/broker/cache/BundlesQuotas.java b/pulsar-broker/src/main/java/org/apache/pulsar/broker/cache/BundlesQuotas.java
@@ -73,7 +73,7 @@ public CompletableFuture<ResourceQuota> getResourceQuota(NamespaceBundle bundle)
     }
 
     public CompletableFuture<ResourceQuota> getResourceQuota(String bundle) {
-        return resourceQuotaCache.get(RESOURCE_QUOTA_ROOT + "/" + bundle.toString())
+        return resourceQuotaCache.get(RESOURCE_QUOTA_ROOT + "/" + bundle)
                 .thenCompose(optResourceQuota -> {
                     if (optResourceQuota.isPresent()) {
                         return CompletableFuture.completedFuture(optResourceQuota.get());

diff --git a/pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/TopicsImpl.java b/pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/TopicsImpl.java
@@ -1602,7 +1602,7 @@ private List<Message<byte[]>> getMessagesFromHttpResponse(String topic, Response
         } else {
             brokerEntryMetadata = new BrokerEntryMetadata();
             if (brokerEntryTimestamp != null) {
-                brokerEntryMetadata.setBrokerTimestamp(DateFormatter.parse(brokerEntryTimestamp.toString()));
+                brokerEntryMetadata.setBrokerTimestamp(DateFormatter.parse(brokerEntryTimestamp));
             }
 
             if (brokerEntryIndex != null) {

diff --git a/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSchemas.java b/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSchemas.java
@@ -139,10 +139,10 @@ void run() throws Exception {
                                     .withPojo(cls)
                                     .withAlwaysAllowNull(alwaysAllowNull)
                                     .build();
-            if (type.toLowerCase().equalsIgnoreCase("avro")) {
+            if (type.equalsIgnoreCase("avro")) {
                 input.setType("AVRO");
                 input.setSchema(SchemaExtractor.getAvroSchemaInfo(schemaDefinition));
-            } else if (type.toLowerCase().equalsIgnoreCase("json")){
+            } else if (type.equalsIgnoreCase("json")){
                 input.setType("JSON");
                 input.setSchema(SchemaExtractor.getJsonSchemaInfo(schemaDefinition));
             }

diff --git a/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/PulsarAdminTool.java b/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/PulsarAdminTool.java
@@ -318,7 +318,7 @@ public static void main(String[] args) throws Exception {
         }
 
         ++cmdPos;
-        boolean isLocalRun = cmdPos < args.length && "localrun".equals(args[cmdPos].toLowerCase());
+        boolean isLocalRun = cmdPos < args.length && "localrun".equalsIgnoreCase(args[cmdPos]);
 
         Function<PulsarAdminBuilder, ? extends PulsarAdmin> adminFactory;
         if (isLocalRun) {

diff --git a/pulsar-common/src/main/java/org/apache/pulsar/common/net/ServiceURI.java b/pulsar-common/src/main/java/org/apache/pulsar/common/net/ServiceURI.java
@@ -220,7 +220,7 @@ private static int getServicePort(String serviceName, String[] serviceInfos) {
             case BINARY_SERVICE:
                 if (serviceInfos.length == 0) {
                     port = BINARY_PORT;
-                } else if (serviceInfos.length == 1 && serviceInfos[0].toLowerCase().equals(SSL_SERVICE)) {
+                } else if (serviceInfos.length == 1 && serviceInfos[0].equalsIgnoreCase(SSL_SERVICE)) {
                     port = BINARY_TLS_PORT;
                 } else {
                     throw new IllegalArgumentException("Invalid pulsar service : " + serviceName + "+"

diff --git a/pulsar-testclient/src/main/java/org/apache/pulsar/testclient/DefaultMessageFormatter.java b/pulsar-testclient/src/main/java/org/apache/pulsar/testclient/DefaultMessageFormatter.java
@@ -50,7 +50,7 @@ public byte[] formatMessage(String producerName, long msgId, byte[] message) {
                 break;
             }
             if (i != 1) {
-                size = Float.valueOf(new String(sMessage.substring(idx+1,idx+i)));
+                size = Float.parseFloat(sMessage.substring(idx + 1, idx + i));
             }
 
             String sub = sMessage.substring(idx, idx+i+1);