[fix][txn]: fix pending ack is recovering throw CursorAlreadyClosedxception #14781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
congbobo184
requested review from
hangc0276,
eolivelli,
315157973,
codelipenghui,
gaoran10 and
zymap
congbobo184
added
doc-not-needed
| @@ -398,7 +398,7 @@ public Entry get() { | |||
| public void readEntriesFailed(ManagedLedgerException exception, Object ctx) { | |||
| if (managedLedger.getConfig().isAutoSkipNonRecoverableData() | |||
| && exception instanceof ManagedLedgerException.NonRecoverableLedgerException | |||
| || exception instanceof ManagedLedgerException.ManagedLedgerFencedException) { | |||
There was a problem hiding this comment.
Why remove the ManagedLedgerFencedException check?
There was a problem hiding this comment.
And from the current implementation, if return isReadable here which means the pending ack reply will be complete, is it expected behavior? https://github.com/apache/pulsar/pull/14781/files#diff-07a1d142ec4105cb65fac733494182b461214a68d735ae1c3f5104c3eb4f92dbL363
There was a problem hiding this comment.
Why remove the
ManagedLedgerFencedExceptioncheck?
we can't delete ManagedLedgerFencedException, that's my mistake
There was a problem hiding this comment.
And from the current implementation, if return
isReadablehere which means the pending ack reply will be complete, is it expected behavior? https://github.com/apache/pulsar/pull/14781/files#diff-07a1d142ec4105cb65fac733494182b461214a68d735ae1c3f5104c3eb4f92dbL363
if ManagedLedgerFencedException or CursorAlreadyClosedxception, the pending ack has been closed so we can stop the recover.
eolivelli
reviewed
Mar 22, 2022
pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/TransactionTest.java
Outdated
Show resolved
Hide resolved
eolivelli
approved these changes
Mar 22, 2022
codelipenghui
approved these changes
Mar 23, 2022
This was referenced Mar 23, 2022
codelipenghui
pushed a commit
that referenced
this pull request
Mar 24, 2022
…14810) ### Motivation When Transactionlog recover fail throw CursorAlreadyClosedException, we should stop the recover op. the cursor was been closed, the transaction log was been closed, so we should stop the recover op, in order to release thread resources like #14781 ### Modifications When recover fail by CursorAlreadyClosedException, comeplete recover
congbobo184
added a commit
that referenced
this pull request
Mar 24, 2022
…14810) ### Motivation When Transactionlog recover fail throw CursorAlreadyClosedException, we should stop the recover op. the cursor was been closed, the transaction log was been closed, so we should stop the recover op, in order to release thread resources like #14781 ### Modifications When recover fail by CursorAlreadyClosedException, comeplete recover (cherry picked from commit a14a97e)
congbobo184
added a commit
that referenced
this pull request
Mar 25, 2022
…eption (#14781) ### Motivation When Transaction PendingAck recover fail throw CursorAlreadyClosedException, we should stop the recover op. the cursor was been closed, the pendingAck was been closed, so we should stop the recover op, in order to release thread resources ``` 02:03:00.072 [pulsar-transaction-executor-4-1] ERROR org.apache.pulsar.broker.transaction.pendingack.impl.MLPendingAckStore - MLPendingAckStore of topic [public/default/persistent/source-topic-partition-13-test__transaction_pending_ack] stat reply fail! org.apache.bookkeeper.mledger.ManagedLedgerException$CursorAlreadyClosedException: Cursor was already closed ``` ### Modifications When recover fail by CursorAlreadyClosedException, comeplete recover ### Verifying this change add test for it (cherry picked from commit 9f30ee9)
codelipenghui
pushed a commit
that referenced
this pull request
Mar 25, 2022
…#14807) ### Motivation When Transaction buffer recover fail throw CursorAlreadyClosedException, we should stop the recover op. the cursor was been closed, the transaction buffer was been closed, so we should stop the recover op, in order to release thread resources like #14781 (cherry picked from commit aef5f6d)
codelipenghui
pushed a commit
that referenced
this pull request
Apr 19, 2022
…eption (#14781) ### Motivation When Transaction PendingAck recover fail throw CursorAlreadyClosedException, we should stop the recover op. the cursor was been closed, the pendingAck was been closed, so we should stop the recover op, in order to release thread resources ``` 02:03:00.072 [pulsar-transaction-executor-4-1] ERROR org.apache.pulsar.broker.transaction.pendingack.impl.MLPendingAckStore - MLPendingAckStore of topic [public/default/persistent/source-topic-partition-13-test__transaction_pending_ack] stat reply fail! org.apache.bookkeeper.mledger.ManagedLedgerException$CursorAlreadyClosedException: Cursor was already closed ``` ### Modifications When recover fail by CursorAlreadyClosedException, comeplete recover ### Verifying this change add test for it (cherry picked from commit 9f30ee9)
codelipenghui
pushed a commit
that referenced
this pull request
Apr 19, 2022
…14810) ### Motivation When Transactionlog recover fail throw CursorAlreadyClosedException, we should stop the recover op. the cursor was been closed, the transaction log was been closed, so we should stop the recover op, in order to release thread resources like #14781 ### Modifications When recover fail by CursorAlreadyClosedException, comeplete recover (cherry picked from commit a14a97e)
codelipenghui
pushed a commit
that referenced
this pull request
Apr 19, 2022
…#14807) ### Motivation When Transaction buffer recover fail throw CursorAlreadyClosedException, we should stop the recover op. the cursor was been closed, the transaction buffer was been closed, so we should stop the recover op, in order to release thread resources like #14781 (cherry picked from commit aef5f6d)
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
…eption (apache#14781) ### Motivation When Transaction PendingAck recover fail throw CursorAlreadyClosedException, we should stop the recover op. the cursor was been closed, the pendingAck was been closed, so we should stop the recover op, in order to release thread resources ``` 02:03:00.072 [pulsar-transaction-executor-4-1] ERROR org.apache.pulsar.broker.transaction.pendingack.impl.MLPendingAckStore - MLPendingAckStore of topic [public/default/persistent/source-topic-partition-13-test__transaction_pending_ack] stat reply fail! org.apache.bookkeeper.mledger.ManagedLedgerException$CursorAlreadyClosedException: Cursor was already closed ``` ### Modifications When recover fail by CursorAlreadyClosedException, comeplete recover ### Verifying this change add test for it
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
…pache#14810) ### Motivation When Transactionlog recover fail throw CursorAlreadyClosedException, we should stop the recover op. the cursor was been closed, the transaction log was been closed, so we should stop the recover op, in order to release thread resources like apache#14781 ### Modifications When recover fail by CursorAlreadyClosedException, comeplete recover
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
…apache#14807) ### Motivation When Transaction buffer recover fail throw CursorAlreadyClosedException, we should stop the recover op. the cursor was been closed, the transaction buffer was been closed, so we should stop the recover op, in order to release thread resources like apache#14781
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When Transaction PendingAck recover fail throw CursorAlreadyClosedException, we should stop the recover op. the cursor was been closed, the pendingAck was been closed, so we should stop the recover op, in order to release thread resources
Modifications
When recover fail by CursorAlreadyClosedException, comeplete recover
Verifying this change
add test for it
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation