[fix][txn]: fix transaction buffer recover throw cursor already close #14807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
congbobo184
added
area/transaction
doc-not-needed
codelipenghui
approved these changes
Mar 23, 2022
|
/pulsarbot run-failure-checks |
gaoran10
reviewed
Mar 24, 2022
...r/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TopicTransactionBuffer.java
Show resolved
Hide resolved
gaoran10
approved these changes
Mar 24, 2022
added 3 commits
March 24, 2022 13:50
…nsaction_buffer_recover_cursor_close_exception
…nsaction_buffer_recover_cursor_close_exception
codelipenghui
pushed a commit
that referenced
this pull request
Mar 25, 2022
…#14807) ### Motivation When Transaction buffer recover fail throw CursorAlreadyClosedException, we should stop the recover op. the cursor was been closed, the transaction buffer was been closed, so we should stop the recover op, in order to release thread resources like #14781 (cherry picked from commit aef5f6d)
codelipenghui
pushed a commit
that referenced
this pull request
Apr 19, 2022
…#14807) ### Motivation When Transaction buffer recover fail throw CursorAlreadyClosedException, we should stop the recover op. the cursor was been closed, the transaction buffer was been closed, so we should stop the recover op, in order to release thread resources like #14781 (cherry picked from commit aef5f6d)
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
…apache#14807) ### Motivation When Transaction buffer recover fail throw CursorAlreadyClosedException, we should stop the recover op. the cursor was been closed, the transaction buffer was been closed, so we should stop the recover op, in order to release thread resources like apache#14781
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When Transaction buffer recover fail throw CursorAlreadyClosedException, we should stop the recover op. the cursor was been closed, the transaction buffer was been closed, so we should stop the recover op, in order to release thread resources
like #14781
Modifications
When recover fail by CursorAlreadyClosedException, comeplete recover
Verifying this change
add test for it
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation