Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix][broker] Fix creating system namespace topic failure. #14949

Merged
merged 6 commits into from
Apr 3, 2022
Merged

[fix][broker] Fix creating system namespace topic failure. #14949

merged 6 commits into from
Apr 3, 2022

Conversation

Technoboy-
Copy link
Contributor

Fixes #14935

Master Issue: #14935

Motivation

When creating system namespace topic, it should always be successful.

Documentation

  • no-need-doc

@Technoboy- Technoboy- self-assigned this Mar 30, 2022
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Mar 30, 2022
@Technoboy- Technoboy- force-pushed the fix-avoid-sys-topic-check branch from f044519 to b55e87f Compare March 31, 2022 01:08
@RobertIndie RobertIndie added type/bug The PR fixed a bug or issue reported a bug area/broker labels Mar 31, 2022
@congbobo184
Copy link
Contributor

congbobo184 commented Mar 31, 2022 •
edited
Loading

pulsar/pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/MLTransactionLogImpl.java

Line 61 in ca436a9

public static final String TRANSACTION_SUBSCRIPTION_NAME = "transaction.subscription";

pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/MLPendingAckStore.java

Line 64 in ca436a9

public static final String PENDING_ACK_STORE_SUFFIX = "__transaction_pending_ack";

pulsar/pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java

Line 66 in ca436a9

public static final TopicName TRANSACTION_COORDINATOR_LOG = TopicName.get(TopicDomain.persistent.value(),

these three topic can't be created to persistent topic, so I think we don't use isSystemTopic() directly

@gaozhangmin
Copy link
Contributor

gaozhangmin commented Mar 31, 2022 •
edited
Loading

pulsar/pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/MLTransactionLogImpl.java

Line 61 in ca436a9

public static final String TRANSACTION_SUBSCRIPTION_NAME = "transaction.subscription";

pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/MLPendingAckStore.java

Line 64 in ca436a9

public static final String PENDING_ACK_STORE_SUFFIX = "__transaction_pending_ack";

pulsar/pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java

Line 66 in ca436a9

public static final TopicName TRANSACTION_COORDINATOR_LOG = TopicName.get(TopicDomain.persistent.value(),

I am a little confused, isAllowAutoTopicCreation should return true for there three topic, right?
And isSystemTopic would return true, because there are in pulsar/system namespace

@Technoboy- Technoboy- force-pushed the fix-avoid-sys-topic-check branch from b9524b6 to d679d05 Compare April 1, 2022 12:21
@Technoboy- Technoboy- force-pushed the fix-avoid-sys-topic-check branch 2 times, most recently from 2f134d9 to efaf42f Compare April 2, 2022 01:45
@Technoboy- Technoboy- force-pushed the fix-avoid-sys-topic-check branch from efaf42f to 66c2bd1 Compare April 2, 2022 04:34
@Technoboy- Technoboy- merged commit f3b87b6 into apache:master Apr 3, 2022
codelipenghui pushed a commit that referenced this pull request Apr 19, 2022
@Technoboy- @codelipenghui
[fix][broker] Fix creating system namespace topic failure. (#14949)
bfeee50 
(cherry picked from commit f3b87b6)
codelipenghui pushed a commit that referenced this pull request Apr 19, 2022
@Technoboy- @codelipenghui
[fix][broker] Fix creating system namespace topic failure. (#14949)
fed8b8c 
(cherry picked from commit f3b87b6)
@codelipenghui codelipenghui added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Apr 19, 2022
Nicklee007 pushed a commit to Nicklee007/pulsar that referenced this pull request Apr 20, 2022
@Technoboy-
[fix][broker] Fix creating system namespace topic failure. (apache#14949
c988610 
)
@Technoboy- Technoboy- mentioned this pull request Apr 21, 2022
Merged
1 task
codelipenghui pushed a commit that referenced this pull request Apr 25, 2022
@Technoboy-
[improve][broker] Tidy up the system topic. (#15252)
aa4df1b 
### Motivation

For #13520, #14643, #14949, we fix some issues related to system topic but result in checking the system topic in different method. So it's better to tidy up the system topic.

So put these system topic names into a new class called SystemTopicNames.
@Technoboy- Technoboy- deleted the fix-avoid-sys-topic-check branch August 10, 2022 05:50
@congbobo184 congbobo184 mentioned this pull request Feb 3, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattisonchao mattisonchao mattisonchao approved these changes

@congbobo184 congbobo184 congbobo184 approved these changes

@RobertIndie RobertIndie RobertIndie approved these changes

@gaoran10 gaoran10 gaoran10 approved these changes

@gaozhangmin gaozhangmin gaozhangmin approved these changes

Assignees

@Technoboy- Technoboy-

Labels
area/broker cherry-picked/branch-2.9 Archived: 2.9 is end of life cherry-picked/branch-2.10 doc-not-needed Your PR changes do not impact docs release/2.9.3 release/2.10.1 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

when allowAutoTopicCreation=false , resource group limit will fail to start
7 participants
@Technoboy- @congbobo184 @gaozhangmin @gaoran10 @RobertIndie @mattisonchao @codelipenghui