[improve][broker] Tidy up the system topic. #15252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Technoboy- Why not add a method to check if a system topic is a transaction related topic? |
We have |
shibd
approved these changes
Apr 22, 2022
codelipenghui
approved these changes
Apr 24, 2022
codelipenghui
added
type/enhancement
congbobo184
approved these changes
Apr 24, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java
Show resolved
Hide resolved
nodece
reviewed
Apr 24, 2022
| @@ -123,7 +125,7 @@ protected void setUpBase(int numBroker,int numPartitionsOfTC, String topic, int | |||
| admin.tenants().createTenant(NamespaceName.SYSTEM_NAMESPACE.getTenant(), | |||
| new TenantInfoImpl(Sets.newHashSet("appid1"), Sets.newHashSet(CLUSTER_NAME))); | |||
| admin.namespaces().createNamespace(NamespaceName.SYSTEM_NAMESPACE.toString()); | |||
| admin.topics().createPartitionedTopic(TopicName.TRANSACTION_COORDINATOR_ASSIGN.toString(), numPartitionsOfTC); | |||
| createTransactionCoordinatorAssign(numPartitionsOfTC); | |||
There was a problem hiding this comment.
I have a question why don't use admin.topics().createPartitionedTopic(TopicName.TRANSACTION_COORDINATOR_ASSIGN.toString(), numPartitionsOfTC); to create topic.
There was a problem hiding this comment.
Ah, because TRANSACTION_COORDINATOR_ASSIGN is not a topic in fact. If we use the old way to create it like createPartitionedTopic , we have to check the name on the broker side to let it pass(like not to create managed ledger or something).
nodece
reviewed
Apr 24, 2022
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerTestBase.java
Outdated
Show resolved
Hide resolved
nodece
approved these changes
Apr 24, 2022
5 tasks
5 tasks
congbobo184
pushed a commit
that referenced
this pull request
May 31, 2023
### Motivation Currently, topics/bundles in `pulsar/system` will be filter while doing shedding, which is introduced by mistake by pr #15252. But we need to unload topics/bundles in `pulsar/system` for load balancing. ### Modifications do not filter topics/bundles in `pulsar/system`.
Technoboy-
pushed a commit
that referenced
this pull request
Jun 5, 2023
### Motivation Currently, topics/bundles in `pulsar/system` will be filter while doing shedding, which is introduced by mistake by pr #15252. But we need to unload topics/bundles in `pulsar/system` for load balancing. ### Modifications do not filter topics/bundles in `pulsar/system`.
RobertIndie
pushed a commit
that referenced
this pull request
Jun 7, 2023
### Motivation Currently, topics/bundles in `pulsar/system` will be filter while doing shedding, which is introduced by mistake by pr #15252. But we need to unload topics/bundles in `pulsar/system` for load balancing. ### Modifications do not filter topics/bundles in `pulsar/system`. (cherry picked from commit 5c74d20)
Technoboy-
pushed a commit
that referenced
this pull request
Dec 4, 2023
### Motivation Currently, topics/bundles in `pulsar/system` will be filter while doing shedding, which is introduced by mistake by pr #15252. But we need to unload topics/bundles in `pulsar/system` for load balancing. ### Modifications do not filter topics/bundles in `pulsar/system`.
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Feb 23, 2024
### Motivation Currently, topics/bundles in `pulsar/system` will be filter while doing shedding, which is introduced by mistake by pr apache#15252. But we need to unload topics/bundles in `pulsar/system` for load balancing. ### Modifications do not filter topics/bundles in `pulsar/system`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For #13520, #14643, #14949, we fix some issues related to system topic but result in checking the system topic in different method. So it's better to tidy up the system topic.
So put these system topic names into a new class called SystemTopicNames.
Documentation
no-need-doc