-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix][broker]Fix topic dispatch rate limiter not init on broker-level #16084
[Fix][broker]Fix topic dispatch rate limiter not init on broker-level #16084
Conversation
9e59a9e
to
1f383c1
Compare
/pulsarbot run-failure-checks |
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
Outdated
Show resolved
Hide resolved
/pulsarbot run-failure-checks |
@Technoboy- @codelipenghui PTAL~, thanks |
@AnonHxy Could you please help open a PR for branch-2.10 since I'm not able to cherry-pick it directly. |
OK, I am working on this. It is better to merge this cherry-pick first #16778. Then it will be easier to resolve the conflict @codelipenghui |
@AnonHxy Done |
…n broker-level apache#16084 (apache#17000) (cherry picked from commit f77696d)
Motivation
DispatchRateLimiter
is disabled at first, then we update only broker-level dispatch rate dynamicly, it will not take affect becausetopic.getDispatchRateLimiter().isPresent()
is false, line:2377pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
Lines 2370 to 2379 in 8914b84
Modifications
updateDispatchRateLimiter()
to initialize and update the dispatch rate limiterVerifying this change
This change added tests and can be verified as follows:
TopicDispatchRateLimiterTest
Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-not-needed