[branch-2.10][cherry-pick] Fix topic dispatch rate limiter not init on broker-level #16084 #17000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnonHxy
force-pushed
the
cherry_pick_523b5c8
branch
from
771f693 to
87d4fd6
Compare
|
@codelipenghui PTAL ~ |
Technoboy-
approved these changes
Aug 10, 2022
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 16, 2022
…n broker-level apache#16084 (apache#17000) (cherry picked from commit f77696d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Cherry-pick #16084
Modifications
TopicDispatchRateLimiterTest:SystemTopicEnabledandopicLevelPoliciesEnabledas true, Becasue the default value of both are false on branch-2.10assertTrue(topic.getDispatchRateLimiter().isEmpty())toassertFalse(topic.getDispatchRateLimiter().isPresent()). Becausejava.util.Optional#isEmptyis present since jdk11, and branch-2.10 java language level is jdk8.Verifying this change
Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)