[fix][meta] fix getChildren in MemoryMetadataStore and EtcdMetadataStore
#18172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderzc
changed the title
getChildren in MemoryMetadataStore and EtcdMetadataStore
Technoboy-
added
type/bug
Technoboy-
approved these changes
Oct 24, 2022
Codecov Report
@@ Coverage Diff @@
## master #18172 +/- ##
=============================================
+ Coverage 34.91% 45.78% +10.87%
- Complexity 5707 17608 +11901
=============================================
Files 607 1579 +972
Lines 53396 128710 +75314
Branches 5712 14153 +8441
=============================================
+ Hits 18644 58932 +40288
- Misses 32119 63748 +31629
- Partials 2633 6030 +3397
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tisonkun
approved these changes
Oct 24, 2022
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Oct 25, 2022
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 10, 2023
…tore (apache#18172) (cherry picked from commit 4ffa741) (cherry picked from commit 3792d63)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 11, 2023
…tore (apache#18172) (cherry picked from commit 4ffa741) (cherry picked from commit 3792d63)
Technoboy-
pushed a commit
that referenced
this pull request
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the current implementation, the
getChildrenwill return incorrect results when getting children paths of/and some special path inMemoryMetadataStoreandEtcdMetadataStore, because we usereplacelead to thebasePathhas been replaced many times.Modifications
Use
replaceFirstinstead ofreplace.Verifying this change
This change is already covered by existing tests, such as testGetChildren.
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: coderzc#16