[ci][fix][broker] fix getChildren in memoryMetadata and etcdMetadata #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [improve][misc] Highlight change to threading Whenever a PR changes the threading model we need to make clear that we should track these changes * Fix typo
…ache#18024) Co-authored-by: huangzegui <huangzegui@didiglobal.com>
…nnel inactive (apache#17856) ### Motivation https://github.com/apache/pulsar/blob/b89c1451551a6bbe681465726906a2e61c9d8a69/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java#L282-L297 The `pendingLookupRequestSemaphore` will leak when channel inactive. There are `LookUpRequestSemaphore` not released when removing it from `pendingRequests` ### Modifications We can't easily release the semaphore in `channelInactive`, because there are not only `LookUpRequest`. So release the semaphore when connectionException ### Verifying this change Add unit test case to cover this change ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc-required` (Your PR needs to update docs and you will update later) - [x] `doc-not-needed` bug fixs, no need doc - [ ] `doc` (Your PR contains doc changes) - [ ] `doc-complete` (Docs have been already added)
…pache#16045) * [fix][proxy] Use correct channel for HAProxyMessage dest address * Fix implementation after researching HAProxy ### Motivation When reading through the Proxy code, I noticed that the `remoteAddress` was used where it probably makes sense to use the `localAddress`. After researching it a bit with the AWS docs https://docs.aws.amazon.com/elasticloadbalancing/latest/classic/enable-proxy-protocol.html and the protocol spec http://www.haproxy.org/download/1.8/doc/proxy-protocol.txt, I think this implementation is correct. We could look at using the value in the broker logs if we wanted to make it clear which proxy the traffic is ingressing through. For now, I propose we just fix the code in the proxy. ### Modifications * Replace `inboundChannel.localAddress` with `inboundChannel.localAddress`. * Fix type checking - [x] `doc-not-needed`
) When using KubernetesRuntime, if uploadBuiltinSinksSources is false (non-default), the originalFileName is not set for builtin components. But with k8s, we need a filename since the component will be downloaded. This results in the component currently being downloaded with the download directory as filename. Also when using a transform function, we use the originalFileName to know if there's a builtin function to download.
Error message is: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
…e#17922) * Make BookieId work with PulsarRegistrationDriver (apache#17762) * Make BookieId work with PulsarRegistrationDriver * Switch to MetadataCache * checkstyle * Do not execute lookup on MetadataCache in the getBookieServiceInfo caller thread
…bug. (apache#17992) Co-authored-by: druidliu <druidliu@tencent.com>
…reduce the execution time (apache#18039)
…22-40149 (apache#18022) * [fix][sec] File tiered storage: upgrade jettison to get rid of CVE-2022-40149 * fix
coderzc
force-pushed
the
fix_get_children
branch
from
34b2c56 to
c1b2351
Compare
coderzc
force-pushed
the
fix_get_children
branch
from
c1b2351 to
40d4456
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.