Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][build] Do not bundle swagger dependencies #20687

Merged
merged 3 commits into from
Jun 30, 2023

Conversation

tisonkun
Copy link
Member

This closes #11313.

Verifying this change

Seamless refactor.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@tisonkun tisonkun added this to the 3.1.0 milestone Jun 29, 2023
@tisonkun tisonkun self-assigned this Jun 29, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jun 29, 2023
Copy link
Contributor

@nicoloboschi nicoloboschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisonkun tisonkun force-pushed the swagger-deps branch 2 times, most recently from 2bad191 to 9d4a96f Compare June 29, 2023 14:48
This closes apache#11313.

Signed-off-by: tison <wander4096@gmail.com>
tisonkun added 2 commits June 30, 2023 11:27
Signed-off-by: tison <wander4096@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #20687 (780de18) into master (0e60340) will increase coverage by 0.49%.
The diff coverage is 82.10%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #20687      +/-   ##
============================================
+ Coverage     72.60%   73.09%   +0.49%     
- Complexity    32018    32063      +45     
============================================
  Files          1855     1869      +14     
  Lines        138569   138838     +269     
  Branches      15250    15271      +21     
============================================
+ Hits         100605   101482     +877     
+ Misses        29945    29302     -643     
- Partials       8019     8054      +35     
Flag Coverage Δ
inttests 24.14% <43.68%> (+0.03%) ⬆️
systests 24.94% <23.68%> (?)
unittests 72.37% <81.57%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ava/org/apache/pulsar/admin/cli/CmdNamespaces.java 76.17% <0.00%> (-0.08%) ⬇️
...ar/common/naming/TopicBundleAssignmentFactory.java 66.66% <66.66%> (ø)
...n/java/org/apache/pulsar/admin/cli/CliCommand.java 57.95% <71.42%> (-1.60%) ⬇️
.../metadata/bookkeeper/PulsarRegistrationClient.java 80.85% <81.11%> (-4.11%) ⬇️
...he/pulsar/broker/admin/v2/NonPersistentTopics.java 62.55% <86.95%> (+0.63%) ⬆️
.../java/org/apache/pulsar/client/cli/CmdProduce.java 52.47% <88.00%> (+3.84%) ⬆️
...org/apache/pulsar/broker/ServiceConfiguration.java 99.38% <100.00%> (+<0.01%) ⬆️
...rg/apache/pulsar/broker/web/PulsarWebResource.java 64.66% <100.00%> (+0.05%) ⬆️
...n/naming/ConsistentHashingTopicBundleAssigner.java 100.00% <100.00%> (ø)
...e/pulsar/common/naming/NamespaceBundleFactory.java 77.04% <100.00%> (+0.25%) ⬆️
... and 2 more

... and 151 files with indirect coverage changes

@tisonkun
Copy link
Member Author

OWASP fails on unrelated deps. We should handle them in another pass.

@tisonkun
Copy link
Member Author

Merging...

@tisonkun tisonkun merged commit d718687 into apache:master Jun 30, 2023
@tisonkun tisonkun deleted the swagger-deps branch June 30, 2023 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swagger dependency scope is too broad
3 participants