-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][cli] Dedicated docs tools #20700
Conversation
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
I'm trying to solve #18932 also and avoid compatibility hack in the site repo. I have an idea and am implementing it. |
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #20700 +/- ##
============================================
+ Coverage 72.69% 73.11% +0.41%
- Complexity 31878 32092 +214
============================================
Files 1871 1868 -3
Lines 138982 138937 -45
Branches 15283 15275 -8
============================================
+ Hits 101037 101585 +548
+ Misses 29873 29306 -567
+ Partials 8072 8046 -26
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pending to merge... |
This closes #18932.
This is a follow-up to #20687. We parse
ApiPropertyModel
annotations when generate docs in the site repo.Factor out a module to handle dependency issues. Also payback some debt that inlines CmdDocGen in core modules.
Verified locally.
I'm preparing a counterpart in the site repo now.See apache/pulsar-site#628Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: