-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][broker] Update TransferShedder underloaded broker check to consider max loaded broker's msgThroughputEMA and update IsExtensibleLoadBalancerImpl check #22321
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22321 +/- ##
============================================
+ Coverage 73.57% 73.80% +0.22%
+ Complexity 32624 32418 -206
============================================
Files 1877 1885 +8
Lines 139502 139881 +379
Branches 15299 15321 +22
============================================
+ Hits 102638 103235 +597
+ Misses 28908 28664 -244
- Partials 7956 7982 +26
Flags with carried forward coverage won't be shown. Click here to find out more.
|
9eb7318
to
f4ab491
Compare
Hi, @mattisonchao I saw you merged this PR , #22379. Can we also merge this too? It appears that CI is broken now? |
…ider max loaded broker's msgThroughputEMA and update IsExtensibleLoadBalancerImpl check
f4ab491
to
1105476
Compare
…ider max loaded broker's msgThroughputEMA and update IsExtensibleLoadBalancerImpl check (apache#22321) (cherry picked from commit d7d5452)
…ider max loaded broker's msgThroughputEMA and update IsExtensibleLoadBalancerImpl check (apache#22321) (cherry picked from commit d7d5452)
…ider max loaded broker's msgThroughputEMA and update IsExtensibleLoadBalancerImpl check (apache#22321) (cherry picked from commit d7d5452)
…ider max loaded broker's msgThroughputEMA and update IsExtensibleLoadBalancerImpl check (apache#22321) (cherry picked from commit d7d5452)
…ider max loaded broker's msgThroughputEMA and update IsExtensibleLoadBalancerImpl check (apache#22321) (apache#22417) (cherry picked from commit 651908a)
…ider max loaded broker's msgThroughputEMA and update IsExtensibleLoadBalancerImpl check (apache#22321) (apache#22417) (cherry picked from commit 651908a)
Motivation
Checking zero traffic is not practical to identify if a broker is too underloaded or not(when first joining the cluster). There might be some health-checking traffic, which might make the broker's traffic slightly bigger than 1 byte/s. We better consider some relative measurements to check if a broker is significantly underloaded.
Modifications
isLoadManagerExtensionEnabled(ServiceConfiguration conf)
to use onlyisLoadManagerExtensionEnabled(PulsarService pulsar)
funcVerifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: