-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][broker] Skip topic.close during unloading if the topic future fails with ownership check, and fix isBundleOwnedByAnyBroker to use ns.checkOwnershipPresentAsync for ExtensibleLoadBalancer #22379
Merged
Technoboy-
merged 2 commits into
apache:master
from
heesung-sn:fix-topic-creation-failure-upon-unloading
Apr 1, 2024
Merged
[fix][broker] Skip topic.close during unloading if the topic future fails with ownership check, and fix isBundleOwnedByAnyBroker to use ns.checkOwnershipPresentAsync for ExtensibleLoadBalancer #22379
Technoboy-
merged 2 commits into
apache:master
from
heesung-sn:fix-topic-creation-failure-upon-unloading
Apr 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
heesung-sn
force-pushed
the
fix-topic-creation-failure-upon-unloading
branch
from
March 28, 2024 19:07
e8c197a
to
8b42318
Compare
…ails with ownership check, and fix isBundleOwnedByAnyBroker to use ns.checkOwnershipPresentAsync for ExtensibleLoadBalancer
heesung-sn
force-pushed
the
fix-topic-creation-failure-upon-unloading
branch
from
March 28, 2024 19:45
8b42318
to
e0cd7c2
Compare
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
Show resolved
Hide resolved
dragosvictor
approved these changes
Mar 29, 2024
Demogorgon314
approved these changes
Mar 30, 2024
Technoboy-
pushed a commit
to Technoboy-/pulsar
that referenced
this pull request
Apr 1, 2024
…ails with ownership check, and fix isBundleOwnedByAnyBroker to use ns.checkOwnershipPresentAsync for ExtensibleLoadBalancer (apache#22379)
15 tasks
heesung-sn
added a commit
to heesung-sn/pulsar
that referenced
this pull request
Apr 2, 2024
…ails with ownership check, and fix isBundleOwnedByAnyBroker to use ns.checkOwnershipPresentAsync for ExtensibleLoadBalancer (apache#22379) (cherry picked from commit 3eb3b1c)
heesung-sn
added a commit
to heesung-sn/pulsar
that referenced
this pull request
Apr 2, 2024
…ails with ownership check, and fix isBundleOwnedByAnyBroker to use ns.checkOwnershipPresentAsync for ExtensibleLoadBalancer (apache#22379) (cherry picked from commit 3eb3b1c)
heesung-sn
added a commit
to heesung-sn/pulsar
that referenced
this pull request
Apr 2, 2024
…ails with ownership check, and fix isBundleOwnedByAnyBroker to use ns.checkOwnershipPresentAsync for ExtensibleLoadBalancer (apache#22379) (cherry picked from commit 3eb3b1c)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 3, 2024
…ails with ownership check, and fix isBundleOwnedByAnyBroker to use ns.checkOwnershipPresentAsync for ExtensibleLoadBalancer (apache#22379) (apache#22406) (cherry picked from commit e664432)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 4, 2024
…ails with ownership check, and fix isBundleOwnedByAnyBroker to use ns.checkOwnershipPresentAsync for ExtensibleLoadBalancer (apache#22379) (apache#22406) (cherry picked from commit e664432)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-3.1
cherry-picked/branch-3.2
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.5
release/3.1.4
release/3.2.3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20157
Motivation
#20157 found that the ExtensibleLoadManagerImplTest init step, unloading the test namespace often fails.
Modifications
Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: