-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][broker] fix exception may hidden and result in stuck when topic loading #23102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hi, @TakaHiR07 I think the reason for the loss of exception is caused by the cast here. and then the type cast caused an exception(NullPoint -> ManagedLedgerException). leading to the loss of all exception information. pulsar/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryImpl.java Line 452 in c9c5bb4
Can you also help fix it here? callback.openLedgerFailed(ManagedLedgerException.getManagedLedgerException(exception.getCause()), ctx); |
… loading (apache#23102) Co-authored-by: fanjianye <fanjianye@bigo.sg> (cherry picked from commit f02ce6c) (cherry picked from commit 61703b8)
… loading (apache#23102) Co-authored-by: fanjianye <fanjianye@bigo.sg> (cherry picked from commit f02ce6c) (cherry picked from commit 61703b8)
… loading (apache#23102) Co-authored-by: fanjianye <fanjianye@bigo.sg> (cherry picked from commit f02ce6c) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
… loading (apache#23102) Co-authored-by: fanjianye <fanjianye@bigo.sg>
Main Issue: #23101
Motivation
As shown in the issue. fix exception may hidden and result in stuck when topic loading
Modifications
catch all exceptions which is throw by persistentTopic construct.
Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete