Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] fix exception may hidden and result in stuck when topic loading #23102

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

TakaHiR07
Copy link
Contributor

Main Issue: #23101

Motivation

As shown in the issue. fix exception may hidden and result in stuck when topic loading

Modifications

catch all exceptions which is throw by persistentTopic construct.

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jul 30, 2024
@lhotari lhotari requested a review from poorbarcode July 31, 2024 06:12
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shibd
Copy link
Member

shibd commented Aug 1, 2024

hi, @TakaHiR07

I think the reason for the loss of exception is caused by the cast here. and then the type cast caused an exception(NullPoint -> ManagedLedgerException). leading to the loss of all exception information.

callback.openLedgerFailed((ManagedLedgerException) exception.getCause(), ctx);

Can you also help fix it here?

      callback.openLedgerFailed(ManagedLedgerException.getManagedLedgerException(exception.getCause()), ctx);

@shibd shibd merged commit f02ce6c into apache:master Aug 2, 2024
55 checks passed
shibd pushed a commit that referenced this pull request Aug 2, 2024
… loading (#23102)

Co-authored-by: fanjianye <fanjianye@bigo.sg>
(cherry picked from commit f02ce6c)
shibd pushed a commit that referenced this pull request Aug 2, 2024
… loading (#23102)

Co-authored-by: fanjianye <fanjianye@bigo.sg>
(cherry picked from commit f02ce6c)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Aug 8, 2024
… loading (apache#23102)

Co-authored-by: fanjianye <fanjianye@bigo.sg>
(cherry picked from commit f02ce6c)
(cherry picked from commit 61703b8)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Aug 12, 2024
… loading (apache#23102)

Co-authored-by: fanjianye <fanjianye@bigo.sg>
(cherry picked from commit f02ce6c)
(cherry picked from commit 61703b8)
nodece pushed a commit to ascentstream/pulsar that referenced this pull request Aug 28, 2024
… loading (apache#23102)

Co-authored-by: fanjianye <fanjianye@bigo.sg>

(cherry picked from commit f02ce6c)
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
grssam pushed a commit to grssam/pulsar that referenced this pull request Sep 4, 2024
… loading (apache#23102)

Co-authored-by: fanjianye <fanjianye@bigo.sg>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants