[fix][broker] type cast on exceptions in exceptionally can lead to lost calls #23117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shibd
added
type/bug
poorbarcode
approved these changes
Aug 2, 2024
lhotari
approved these changes
Aug 2, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23117 +/- ##
============================================
- Coverage 73.57% 73.44% -0.13%
- Complexity 32624 33222 +598
============================================
Files 1877 1919 +42
Lines 139502 144103 +4601
Branches 15299 15744 +445
============================================
+ Hits 102638 105836 +3198
- Misses 28908 30149 +1241
- Partials 7956 8118 +162
Flags with carried forward coverage won't be shown. Click here to find out more.
|
shibd
added a commit
to shibd/pulsar
that referenced
this pull request
Aug 2, 2024
…st calls (apache#23117) (cherry picked from commit 12588a8)
shibd
added a commit
to shibd/pulsar
that referenced
this pull request
Aug 2, 2024
…st calls (apache#23117) (cherry picked from commit 12588a8)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 8, 2024
…st calls (apache#23117) (cherry picked from commit 12588a8) (cherry picked from commit 9483457)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 12, 2024
…st calls (apache#23117) (cherry picked from commit 12588a8) (cherry picked from commit 9483457)
grssam
pushed a commit
to grssam/pulsar
that referenced
this pull request
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From: #23102 (comment)
Motivation
Typecast on exceptions failed in
future.exceptionallywill cause lost calls, and not having any log.Modifications
Ensure that all conversions of
ManagedLedgerExceptionare preceded by checks.Verifying this change
Documentation
docdoc-requireddoc-not-neededdoc-complete