Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translate documents into japanese #285

Merged
merged 6 commits into from
Mar 17, 2017
Merged

translate documents into japanese #285

merged 6 commits into from
Mar 17, 2017

Conversation

hrsakai
Copy link
Contributor

@hrsakai hrsakai commented Mar 10, 2017

Motivation

Japanese documents does not exist.

Modifications

added japanese documents under docs/locale/ja.

Result

can read douments in japanese.

@rdhabalia rdhabalia added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Mar 10, 2017
@rdhabalia rdhabalia added this to the 1.17 milestone Mar 10, 2017
Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive effort!

I cannot comment on the quality of the translation ;) so I only leave a couple of notes:

  • Add a link to the translation in the main Documentation.md page
  • Avoid including the same images/logo again. Instead reference the same files under doc/images folder, unless you're going to translate the text inside the images

@saandrews
Copy link
Contributor

We are trying to get some help to review it. Will update in few days.

### Consumer

ConsumerはSubscriptionへの接続とそこからのメッセージのconsumeに利用されます。
接続後、クライアントはトピックをsubscribeする必要があります。
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

「Subscription position」を「購読位置」と表現されている部分がありますが、「subscribeする」は「購読する」と表現するのはだめでしょうか。同様に「consumeする」や「produceする」なども日本語として違和感を感じましたが、この方が理解しやすいということでしょうか。

Copy link
Contributor Author

@hrsakai hrsakai Mar 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確認ありがとうございます。

再度検討しまして、下記のようにしました。(修正:b8287c3)

produce: 訳さない
consume: 訳さない
publish: 発行
subscribe: 購読
unsubscribe: 購読解除
subscription: サブスクリプション
  • Subscriptionという単語はpulsarのリソースの(Subscription)を指しているため、購読と訳さずに他のリソース(Topicなど)と同じようにカタカナに合わせました。
  • produce/consumeは、pulsarのコマンドなどでも利用されている言葉なので訳さない方が適切と考えております。(またMQで一般的な用語というのもあり。)
    *また 購読位置は、そのまま購読位置と訳すのが適切と考えそのままにしました。(pulsarのリソースのSubscriptionとは関係なく)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

なるほど。理解しました 👍

メッセージ・メタデータは、アプリケーションに指定されたペイロードとともに、
シリアライズされたProtocol Buffersオブジェクトとして保存されます。

メターデータはProducerに作成され、変更されることなくConsumerに渡されます。
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

メタデータでしょうか。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

指摘ありがとうございます。
修正しました。

@hrsakai
Copy link
Contributor Author

hrsakai commented Mar 14, 2017

@merlimat @saandrews
I did Add a link to the translation in the main Documentation.md page and Instead reference the same files under doc/images folder. please, check them(a17a3cb 2ec6cfe).

admin.brokers().getOwnedNamespaces(cluster,brokerUrl)
```


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recently we have added additional broker-api which we may want to add: updateDynamicConfiguration

Copy link
Contributor Author

@hrsakai hrsakai Mar 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we translated v1.16 documents.
so we will add next time when we translate v1.17.

https://github.com/yahoo/pulsar/pull/285/files#diff-89757a334be7e0c5756a8a2b14ecdfd6R1
In japanese, this line means we translated v1.16.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, make sense.


### 認証と認可

TODO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we missed to add Authentication and Authorization

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it has already been added at the latest,
we will also update here next time when we translate v1.17

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure.

@okuryu
Copy link

okuryu commented Mar 14, 2017

+1 for the quality of translation as a first version.

Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@rdhabalia rdhabalia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 really great effort.

@rdhabalia rdhabalia merged commit bd3fbb2 into apache:master Mar 17, 2017
hrsakai pushed a commit to hrsakai/pulsar that referenced this pull request Dec 10, 2020
hangc0276 pushed a commit to hangc0276/pulsar that referenced this pull request May 26, 2021
fixes apache#284

pulsar will add a updateRates method for this PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants