-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
translate documents into japanese #285
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impressive effort!
I cannot comment on the quality of the translation ;) so I only leave a couple of notes:
- Add a link to the translation in the main Documentation.md page
- Avoid including the same images/logo again. Instead reference the same files under
doc/images
folder, unless you're going to translate the text inside the images
We are trying to get some help to review it. Will update in few days. |
docs/locale/ja/BinaryProtocol.md
Outdated
### Consumer | ||
|
||
ConsumerはSubscriptionへの接続とそこからのメッセージのconsumeに利用されます。 | ||
接続後、クライアントはトピックをsubscribeする必要があります。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
「Subscription position」を「購読位置」と表現されている部分がありますが、「subscribeする」は「購読する」と表現するのはだめでしょうか。同様に「consumeする」や「produceする」なども日本語として違和感を感じましたが、この方が理解しやすいということでしょうか。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
確認ありがとうございます。
再度検討しまして、下記のようにしました。(修正:b8287c3)
produce: 訳さない
consume: 訳さない
publish: 発行
subscribe: 購読
unsubscribe: 購読解除
subscription: サブスクリプション
- Subscriptionという単語はpulsarのリソースの(Subscription)を指しているため、購読と訳さずに他のリソース(Topicなど)と同じようにカタカナに合わせました。
- produce/consumeは、pulsarのコマンドなどでも利用されている言葉なので訳さない方が適切と考えております。(またMQで一般的な用語というのもあり。)
*また 購読位置は、そのまま購読位置と訳すのが適切と考えそのままにしました。(pulsarのリソースのSubscriptionとは関係なく)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
なるほど。理解しました 👍
docs/locale/ja/BinaryProtocol.md
Outdated
メッセージ・メタデータは、アプリケーションに指定されたペイロードとともに、 | ||
シリアライズされたProtocol Buffersオブジェクトとして保存されます。 | ||
|
||
メターデータはProducerに作成され、変更されることなくConsumerに渡されます。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
メタデータでしょうか。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
指摘ありがとうございます。
修正しました。
@merlimat @saandrews |
admin.brokers().getOwnedNamespaces(cluster,brokerUrl) | ||
``` | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recently we have added additional broker-api which we may want to add: updateDynamicConfiguration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we translated v1.16 documents.
so we will add next time when we translate v1.17.
https://github.com/yahoo/pulsar/pull/285/files#diff-89757a334be7e0c5756a8a2b14ecdfd6R1
In japanese, this line means we translated v1.16.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, make sense.
|
||
### 認証と認可 | ||
|
||
TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we missed to add Authentication
and Authorization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it has already been added at the latest,
we will also update here next time when we translate v1.17
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure.
+1 for the quality of translation as a first version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 really great effort.
fixes apache#284 pulsar will add a updateRates method for this PR.
Motivation
Japanese documents does not exist.
Modifications
added japanese documents under docs/locale/ja.
Result
can read douments in japanese.