Fix message not dispatch for key_shared sub type in non-persistent su… #9826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@codelipenghui added unit test, PTAL |
codelipenghui
approved these changes
Mar 14, 2021
|
@MarvinCai Could you please also take a look at the |
|
@codelipenghui updated the test. |
codelipenghui
approved these changes
Mar 14, 2021
codelipenghui
requested review from
merlimat,
315157973,
hangc0276,
jiazhai,
sijie and
zymap
|
/pulsarbot rerun-failure-checks |
sijie
approved these changes
Mar 16, 2021
fmiguelez
pushed a commit
to fmiguelez/pulsar
that referenced
this pull request
Mar 16, 2021
apache#9826) Fixes apache#9703 ### Motivation With a non-persistent topic, I see messages published in the topic stats, but consumers do not consume them if they use Key_Shared. Other consumer modes work fine. ### Verifying this change Covered by existing test case, verified manually.
codelipenghui
added
cherry-picked/branch-2.7
codelipenghui
pushed a commit
that referenced
this pull request
Mar 24, 2021
#9826) Fixes #9703 ### Motivation With a non-persistent topic, I see messages published in the topic stats, but consumers do not consume them if they use Key_Shared. Other consumer modes work fine. ### Verifying this change Covered by existing test case, verified manually. (cherry picked from commit 960a79e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9703
Motivation
With a non-persistent topic, I see messages published in the topic stats, but consumers do not consume them if they use Key_Shared. Other consumer modes work fine.
Verifying this change
Covered by existing test case, verified manually.