forked from apache/pulsar
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix message not dispatch for key_shared sub type in non-persistent su… (
apache#9826) Fixes apache#9703 ### Motivation With a non-persistent topic, I see messages published in the topic stats, but consumers do not consume them if they use Key_Shared. Other consumer modes work fine. ### Verifying this change Covered by existing test case, verified manually.
- Loading branch information
Showing
3 changed files
with
189 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
163 changes: 163 additions & 0 deletions
163
...r/broker/service/nonpersistent/NonPersistentStickyKeyDispatcherMultipleConsumersTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,163 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.pulsar.broker.service.nonpersistent; | ||
|
|
||
| import io.netty.buffer.ByteBuf; | ||
| import io.netty.buffer.Unpooled; | ||
| import io.netty.channel.ChannelPromise; | ||
| import org.apache.bookkeeper.mledger.Entry; | ||
| import org.apache.bookkeeper.mledger.impl.EntryImpl; | ||
| import org.apache.pulsar.broker.PulsarService; | ||
| import org.apache.pulsar.broker.ServiceConfiguration; | ||
| import org.apache.pulsar.broker.service.BrokerService; | ||
| import org.apache.pulsar.broker.service.BrokerServiceException; | ||
| import org.apache.pulsar.broker.service.Consumer; | ||
| import org.apache.pulsar.broker.service.EntryBatchSizes; | ||
| import org.apache.pulsar.broker.service.HashRangeAutoSplitStickyKeyConsumerSelector; | ||
| import org.apache.pulsar.broker.service.RedeliveryTracker; | ||
| import org.apache.pulsar.broker.service.persistent.DispatchRateLimiter; | ||
| import org.apache.pulsar.common.api.proto.MessageMetadata; | ||
| import org.apache.pulsar.common.protocol.Commands; | ||
| import org.powermock.api.mockito.PowerMockito; | ||
| import org.powermock.core.classloader.annotations.PowerMockIgnore; | ||
| import org.powermock.core.classloader.annotations.PrepareForTest; | ||
| import org.testng.IObjectFactory; | ||
| import org.testng.annotations.BeforeMethod; | ||
| import org.testng.annotations.ObjectFactory; | ||
| import org.testng.annotations.Test; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
| import java.util.Optional; | ||
|
|
||
| import static java.nio.charset.StandardCharsets.UTF_8; | ||
| import static org.apache.pulsar.common.protocol.Commands.serializeMetadataAndPayload; | ||
| import static org.mockito.ArgumentMatchers.any; | ||
| import static org.mockito.ArgumentMatchers.anyInt; | ||
| import static org.mockito.ArgumentMatchers.anyLong; | ||
| import static org.mockito.ArgumentMatchers.anyString; | ||
| import static org.mockito.ArgumentMatchers.eq; | ||
| import static org.mockito.Mockito.doAnswer; | ||
| import static org.mockito.Mockito.doReturn; | ||
| import static org.mockito.Mockito.mock; | ||
| import static org.mockito.Mockito.times; | ||
| import static org.mockito.Mockito.verify; | ||
| import static org.testng.Assert.assertEquals; | ||
| import static org.testng.Assert.fail; | ||
|
|
||
| @PrepareForTest({ DispatchRateLimiter.class }) | ||
| @PowerMockIgnore({"org.apache.logging.log4j.*"}) | ||
| public class NonPersistentStickyKeyDispatcherMultipleConsumersTest { | ||
|
|
||
| private PulsarService pulsarMock; | ||
| private BrokerService brokerMock; | ||
| private NonPersistentTopic topicMock; | ||
| private NonPersistentSubscription subscriptionMock; | ||
| private ServiceConfiguration configMock; | ||
| private ChannelPromise channelMock; | ||
|
|
||
| private NonPersistentStickyKeyDispatcherMultipleConsumers nonpersistentDispatcher; | ||
|
|
||
| final String topicName = "non-persistent://public/default/testTopic"; | ||
|
|
||
| @ObjectFactory | ||
| public IObjectFactory getObjectFactory() { | ||
| return new org.powermock.modules.testng.PowerMockObjectFactory(); | ||
| } | ||
|
|
||
| @BeforeMethod | ||
| public void setup() throws Exception { | ||
| configMock = mock(ServiceConfiguration.class); | ||
| doReturn(true).when(configMock).isSubscriptionRedeliveryTrackerEnabled(); | ||
| doReturn(100).when(configMock).getDispatcherMaxReadBatchSize(); | ||
| doReturn(true).when(configMock).isSubscriptionKeySharedUseConsistentHashing(); | ||
| doReturn(1).when(configMock).getSubscriptionKeySharedConsistentHashingReplicaPoints(); | ||
|
|
||
| pulsarMock = mock(PulsarService.class); | ||
| doReturn(configMock).when(pulsarMock).getConfiguration(); | ||
|
|
||
| brokerMock = mock(BrokerService.class); | ||
| doReturn(pulsarMock).when(brokerMock).pulsar(); | ||
|
|
||
| topicMock = mock(NonPersistentTopic.class); | ||
| doReturn(brokerMock).when(topicMock).getBrokerService(); | ||
| doReturn(topicName).when(topicMock).getName(); | ||
|
|
||
| channelMock = mock(ChannelPromise.class); | ||
| subscriptionMock = mock(NonPersistentSubscription.class); | ||
|
|
||
| PowerMockito.mockStatic(DispatchRateLimiter.class); | ||
| PowerMockito.when(DispatchRateLimiter.isDispatchRateNeeded( | ||
| any(BrokerService.class), | ||
| any(Optional.class), | ||
| anyString(), | ||
| any(DispatchRateLimiter.Type.class)) | ||
| ).thenReturn(false); | ||
|
|
||
| nonpersistentDispatcher = new NonPersistentStickyKeyDispatcherMultipleConsumers( | ||
| topicMock, subscriptionMock, | ||
| new HashRangeAutoSplitStickyKeyConsumerSelector()); | ||
| } | ||
|
|
||
| @Test(timeOut = 10000) | ||
| public void testSendMessage() throws BrokerServiceException { | ||
| Consumer consumerMock = mock(Consumer.class); | ||
| nonpersistentDispatcher.addConsumer(consumerMock); | ||
|
|
||
| List<Entry> entries = new ArrayList<>(); | ||
| entries.add(EntryImpl.create(1, 1, createMessage("message1", 1))); | ||
| entries.add(EntryImpl.create(1, 2, createMessage("message2", 2))); | ||
| doAnswer(invocationOnMock -> { | ||
| ChannelPromise mockPromise = mock(ChannelPromise.class); | ||
| List<Entry> receivedEntries = invocationOnMock.getArgument(0, List.class); | ||
| for (int index = 1; index <= receivedEntries.size(); index++) { | ||
| Entry entry = receivedEntries.get(index - 1); | ||
| assertEquals(entry.getLedgerId(), 1); | ||
| assertEquals(entry.getEntryId(), index); | ||
| ByteBuf byteBuf = entry.getDataBuffer(); | ||
| MessageMetadata messageMetadata = Commands.parseMessageMetadata(byteBuf); | ||
| assertEquals(byteBuf.toString(UTF_8), "message" + index); | ||
| }; | ||
| return mockPromise; | ||
| }).when(consumerMock).sendMessages(any(List.class), any(EntryBatchSizes.class), any(), | ||
| anyInt(), anyLong(), anyLong(), any(RedeliveryTracker.class)); | ||
| try { | ||
| nonpersistentDispatcher.sendMessages(entries); | ||
| } catch (Exception e) { | ||
| fail("Failed to sendMessages.", e); | ||
| } | ||
| verify(consumerMock, times(1)).sendMessages(any(List.class), any(EntryBatchSizes.class), | ||
| eq(null), anyInt(), anyLong(), anyLong(), any(RedeliveryTracker.class)); | ||
| } | ||
|
|
||
| private ByteBuf createMessage(String message, int sequenceId) { | ||
| return createMessage(message, sequenceId, "testKey"); | ||
| } | ||
|
|
||
| private ByteBuf createMessage(String message, int sequenceId, String key) { | ||
| MessageMetadata messageMetadata = new MessageMetadata() | ||
| .setSequenceId(sequenceId) | ||
| .setProducerName("testProducer") | ||
| .setPartitionKey(key) | ||
| .setPartitionKeyB64Encoded(false) | ||
| .setPublishTime(System.currentTimeMillis()); | ||
| return serializeMetadataAndPayload(Commands.ChecksumType.Crc32c, messageMetadata, Unpooled.copiedBuffer(message.getBytes(UTF_8))); | ||
| } | ||
|
|
||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters