Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Move the judgment logic of grpc TLS mode to improve the scalability of ProtocolNegotiator #6866

Closed
1 task done
dingshuangxi888 opened this issue Jun 7, 2023 · 0 comments · Fixed by #6867
Closed
1 task done

[Enhancement] Move the judgment logic of grpc TLS mode to improve the scalability of ProtocolNegotiator #6866

dingshuangxi888 opened this issue Jun 7, 2023 · 0 comments · Fixed by #6867
Labels
type/enhancement

Comments

@dingshuangxi888
Copy link
Contributor

dingshuangxi888 commented Jun 7, 2023 •
edited
Loading

Before Creating the Enhancement Request

  • The SslContext is created out of ProxyAndTlsProtocolNegotiator，so the ProxyAndTlsProtocolNegotiator cannot be extended to support more protocols.

Summary

Move the judgment logic of grpc TLS mode to improve the scalability of ProtocolNegotiator, so the ProxyAndTlsProtocolHandler can be reused when we need to support more protocol.

Motivation

Move the judgment logic of grpc TLS mode to improve the scalability of ProtocolNegotiator, so the ProxyAndTlsProtocolHandler can be reused when we need to support more protocol such as proxy protocol.

Describe the Solution You'd Like

Move the judgment logic of grpc TLS mode to improve the scalability of ProtocolNegotiator, so the ProxyAndTlsProtocolHandler can be reused when we need to support more protocol such as proxy protocol.

Describe Alternatives You've Considered

No.

Additional Context

No response
@dingshuangxi888 dingshuangxi888 mentioned this issue Jun 7, 2023
Merged
@dingshuangxi888 dingshuangxi888 changed the title [Enhancement] Support dynamic modification of grpc TLS mode to improve the scalability of ProtocolNegotiator [Enhancement] Move the judgment logic of grpc TLS mode to improve the scalability of ProtocolNegotiator Jun 7, 2023
xdkxlk pushed a commit that referenced this issue Jun 8, 2023
@dingshuangxi888
[ISSUE #6866] Move the judgment logic of grpc TLS mode to improve the…
4d82b30 
… scalability of ProtocolNegotiator (#6867)

[ISSUE #6866] Move the judgment logic of grpc TLS mode to improve the scalability of ProtocolNegotiator

---------

Co-authored-by: 徒钟 <shuangxi.dsx@alibaba-inc.com>
drpmma pushed a commit that referenced this issue Jul 11, 2023
@dingshuangxi888
[ISSUE #7010] Fix the HandshakeHandler returns when detect haproxy ve…
b4496be 
…rsion need more data (#7011)

* Support dynamic modification of grpc tls mode to improve the scalability of ProtocolNegotiator

* Support dynamic modification of grpc tls mode to improve the scalability of ProtocolNegotiator

* [ISSUE #6866] Move the judgment logic of grpc TLS mode to improve the scalability of ProtocolNegotiator

* [ISSUE #6866] Move the judgment logic of grpc TLS mode to improve the scalability of ProtocolNegotiator

* [ISSUE #6866] Move the judgment logic of grpc TLS mode to improve the scalability of ProtocolNegotiator

* [ISSUE #6866] Move the judgment logic of grpc TLS mode to improve the scalability of ProtocolNegotiator

* Support proxy protocol for gRPC server.

* Support proxy protocol for gRPC server.

* Support proxy protocol for gRPC server.

* Support proxy protocol for gRPC server.

* Support proxy protocol for gRPC server.

* Support proxy protocol for gRPC and Remoting server.

* 回滚netty的升级

* Support proxy protocol for gRPC and Remoting server.

* Support proxy protocol for gRPC and Remoting server.

* Support proxy protocol for gRPC and Remoting server.

* add grpc-netty-codec-haproxy in bazel

* add grpc-netty-codec-haproxy in bazel

* Support proxy protocol for gRPC and Remoting server.

* Fix Test

* add grpc-netty-codec-haproxy in bazel

* add ProxyProtocolTest for Remoting

* Move AttributeKey from RemotingHelper to AttributeKey.

* Fix the needs more data for HandshakeHandler.

* Fix the needs more data for HandshakeHandler.

* Fix the needs more data for HandshakeHandler.

* Fix the needs more data for HandshakeHandler.

---------

Co-authored-by: 徒钟 <shuangxi.dsx@alibaba-inc.com>
lollipopjin pushed a commit that referenced this issue Jul 21, 2023
@dingshuangxi888
[ISSUE #7061] Support forward HAProxyMessage for Multi Protocol serve…
90c5382 
…r. (#7062)

* Support dynamic modification of grpc tls mode to improve the scalability of ProtocolNegotiator

* Support dynamic modification of grpc tls mode to improve the scalability of ProtocolNegotiator

* [ISSUE #6866] Move the judgment logic of grpc TLS mode to improve the scalability of ProtocolNegotiator

* [ISSUE #6866] Move the judgment logic of grpc TLS mode to improve the scalability of ProtocolNegotiator

* [ISSUE #6866] Move the judgment logic of grpc TLS mode to improve the scalability of ProtocolNegotiator

* [ISSUE #6866] Move the judgment logic of grpc TLS mode to improve the scalability of ProtocolNegotiator

* Support proxy protocol for gRPC server.

* Support proxy protocol for gRPC server.

* Support proxy protocol for gRPC server.

* Support proxy protocol for gRPC server.

* Support proxy protocol for gRPC server.

* Support proxy protocol for gRPC and Remoting server.

* 回滚netty的升级

* Support proxy protocol for gRPC and Remoting server.

* Support proxy protocol for gRPC and Remoting server.

* Support proxy protocol for gRPC and Remoting server.

* add grpc-netty-codec-haproxy in bazel

* add grpc-netty-codec-haproxy in bazel

* Support proxy protocol for gRPC and Remoting server.

* Fix Test

* add grpc-netty-codec-haproxy in bazel

* add ProxyProtocolTest for Remoting

* Support HAProxyMessage forward for multi protocol server.

---------

Co-authored-by: 徒钟 <shuangxi.dsx@alibaba-inc.com>
lizhimins pushed a commit to lizhimins/rocketmq that referenced this issue Jul 26, 2023
@dingshuangxi888 @lizhimins
[ISSUE apache#7010] Fix the HandshakeHandler returns when detect hapr…
3b47902 
…oxy version need more data (apache#7011)

* Support dynamic modification of grpc tls mode to improve the scalability of ProtocolNegotiator

* Support dynamic modification of grpc tls mode to improve the scalability of ProtocolNegotiator

* [ISSUE apache#6866] Move the judgment logic of grpc TLS mode to improve the scalability of ProtocolNegotiator

* [ISSUE apache#6866] Move the judgment logic of grpc TLS mode to improve the scalability of ProtocolNegotiator

* [ISSUE apache#6866] Move the judgment logic of grpc TLS mode to improve the scalability of ProtocolNegotiator

* [ISSUE apache#6866] Move the judgment logic of grpc TLS mode to improve the scalability of ProtocolNegotiator

* Support proxy protocol for gRPC server.

* Support proxy protocol for gRPC server.

* Support proxy protocol for gRPC server.

* Support proxy protocol for gRPC server.

* Support proxy protocol for gRPC server.

* Support proxy protocol for gRPC and Remoting server.

* 回滚netty的升级

* Support proxy protocol for gRPC and Remoting server.

* Support proxy protocol for gRPC and Remoting server.

* Support proxy protocol for gRPC and Remoting server.

* add grpc-netty-codec-haproxy in bazel

* add grpc-netty-codec-haproxy in bazel

* Support proxy protocol for gRPC and Remoting server.

* Fix Test

* add grpc-netty-codec-haproxy in bazel

* add ProxyProtocolTest for Remoting

* Move AttributeKey from RemotingHelper to AttributeKey.

* Fix the needs more data for HandshakeHandler.

* Fix the needs more data for HandshakeHandler.

* Fix the needs more data for HandshakeHandler.

* Fix the needs more data for HandshakeHandler.

---------

Co-authored-by: 徒钟 <shuangxi.dsx@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #6866] Move the judgment logic of grpc TLS mode to improve the scalability of ProtocolNegotiator
1 participant
@dingshuangxi888