[ISSUE #6866] Move the judgment logic of grpc TLS mode to improve the scalability of ProtocolNegotiator #6867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity of ProtocolNegotiator
xdkxlk
reviewed
Jun 7, 2023
| this.ssl = ssl; | ||
| this.plaintext = plaintext; | ||
| public PortUnificationServerHandler(GrpcHttp2ConnectionHandler grpcHandler) { | ||
| this.ssl = InternalProtocolNegotiators.serverTls(loadSslContext()) |
There was a problem hiding this comment.
SslContext is only need to loaded once
There was a problem hiding this comment.
Yes, it has been fixed, please review again.
…ity of ProtocolNegotiator
dingshuangxi888
changed the title
added 4 commits
June 7, 2023 16:33
… scalability of ProtocolNegotiator
… scalability of ProtocolNegotiator
… scalability of ProtocolNegotiator
… scalability of ProtocolNegotiator
xdkxlk
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support dynamic modification of grpc TLS mode to improve the scalability of ProtocolNegotiator
Which Issue(s) This PR Fixes
Fixes #6866
Brief Description
Support dynamic modification of grpc TLS mode to improve the scalability of ProtocolNegotiator
How Did You Test This Change?
Yes.