[ISSUE #8384] Add more test coverage for ClientConfig #8385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8385 +/- ##
=============================================
+ Coverage 44.22% 44.29% +0.07%
- Complexity 10727 10768 +41
=============================================
Files 1274 1274
Lines 88939 88951 +12
Branches 11432 11433 +1
=============================================
+ Hits 39330 39398 +68
+ Misses 44636 44592 -44
+ Partials 4973 4961 -12 ☔ View full report in Codecov by Sentry. |
RongtongJin
reviewed
Jul 14, 2024
Comment on lines
47
to
68
| public void assertClientConfig() { | ||
| assertEquals("unitName", clientConfig.getUnitName()); | ||
| assertEquals("127.0.0.1", clientConfig.getClientIP()); | ||
| assertEquals(1, clientConfig.getClientCallbackExecutorThreads()); | ||
| assertEquals(1000 * 30, clientConfig.getPollNameServerInterval()); | ||
| assertEquals(1000 * 30, clientConfig.getHeartbeatBrokerInterval()); | ||
| assertEquals(1000 * 5, clientConfig.getPersistConsumerOffsetInterval()); | ||
| assertEquals(1000, clientConfig.getPullTimeDelayMillsWhenException()); | ||
| assertEquals("{}", clientConfig.getSocksProxyConfig()); | ||
| assertEquals(LanguageCode.JAVA, clientConfig.getLanguage()); | ||
| assertEquals(AccessChannel.LOCAL, clientConfig.getAccessChannel()); | ||
| assertEquals(1000 * 3, clientConfig.getMqClientApiTimeout()); | ||
| assertEquals(200, clientConfig.getDetectTimeout()); | ||
| assertEquals(1000 * 2, clientConfig.getDetectInterval()); | ||
| assertTrue(clientConfig.isUnitMode()); | ||
| assertTrue(clientConfig.isDecodeReadBody()); | ||
| assertTrue(clientConfig.isDecodeDecompressBody()); | ||
| assertTrue(clientConfig.isEnableStreamRequestType()); | ||
| assertTrue(clientConfig.isSendLatencyEnable()); | ||
| assertTrue(clientConfig.isEnableHeartbeatChannelEventListener()); | ||
| assertFalse(clientConfig.isUseHeartbeatV2()); | ||
| } |
There was a problem hiding this comment.
This test doesn't seem to make much sense
There was a problem hiding this comment.
This test doesn't seem to make much sense
OK, I'll remove it.
|
@RongtongJin Done, please review, thank you. |
daniel-y
approved these changes
Jul 15, 2024
zhouxinyu
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8384 .
before:
after:
