Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8384] Add more test coverage for ClientConfig #8385

Merged
merged 4 commits into from
Jul 15, 2024
Merged
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
119 changes: 119 additions & 0 deletions client/src/test/java/org/apache/rocketmq/client/ClientConfigTest.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,119 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.rocketmq.client;

import org.apache.rocketmq.common.message.MessageQueue;
import org.apache.rocketmq.remoting.protocol.LanguageCode;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.junit.MockitoJUnitRunner;

import java.util.Collection;
import java.util.Collections;
import java.util.Set;

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;

@RunWith(MockitoJUnitRunner.class)
public class ClientConfigTest {

private ClientConfig clientConfig;

private final String resource = "resource";

@Before
public void init() {
clientConfig = createClientConfig();
}

@Test
public void assertClientConfig() {
assertEquals("unitName", clientConfig.getUnitName());
assertEquals("127.0.0.1", clientConfig.getClientIP());
assertEquals(1, clientConfig.getClientCallbackExecutorThreads());
assertEquals(1000 * 30, clientConfig.getPollNameServerInterval());
assertEquals(1000 * 30, clientConfig.getHeartbeatBrokerInterval());
assertEquals(1000 * 5, clientConfig.getPersistConsumerOffsetInterval());
assertEquals(1000, clientConfig.getPullTimeDelayMillsWhenException());
assertEquals("{}", clientConfig.getSocksProxyConfig());
assertEquals(LanguageCode.JAVA, clientConfig.getLanguage());
assertEquals(AccessChannel.LOCAL, clientConfig.getAccessChannel());
assertEquals(1000 * 3, clientConfig.getMqClientApiTimeout());
assertEquals(200, clientConfig.getDetectTimeout());
assertEquals(1000 * 2, clientConfig.getDetectInterval());
assertTrue(clientConfig.isUnitMode());
assertTrue(clientConfig.isDecodeReadBody());
assertTrue(clientConfig.isDecodeDecompressBody());
assertTrue(clientConfig.isEnableStreamRequestType());
assertTrue(clientConfig.isSendLatencyEnable());
assertTrue(clientConfig.isEnableHeartbeatChannelEventListener());
assertFalse(clientConfig.isUseHeartbeatV2());
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test doesn't seem to make much sense

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test doesn't seem to make much sense

OK, I'll remove it.


@Test
public void testWithNamespace() {
Set<String> resources = clientConfig.withNamespace(Collections.singleton(resource));
assertTrue(resources.contains("lmq%resource"));
}

@Test
public void testWithoutNamespace() {
String actual = clientConfig.withoutNamespace(resource);
assertEquals(resource, actual);
Set<String> resources = clientConfig.withoutNamespace(Collections.singleton(resource));
assertTrue(resources.contains(resource));
}

@Test
public void testQueuesWithNamespace() {
MessageQueue messageQueue = new MessageQueue();
messageQueue.setTopic("defaultTopic");
Collection<MessageQueue> messageQueues = clientConfig.queuesWithNamespace(Collections.singleton(messageQueue));
assertTrue(messageQueues.contains(messageQueue));
assertEquals("lmq%defaultTopic", messageQueues.iterator().next().getTopic());
}

private ClientConfig createClientConfig() {
ClientConfig result = new ClientConfig();
result.setUnitName("unitName");
result.setClientIP("127.0.0.1");
result.setClientCallbackExecutorThreads(1);
result.setPollNameServerInterval(1000 * 30);
result.setHeartbeatBrokerInterval(1000 * 30);
result.setPersistConsumerOffsetInterval(1000 * 5);
result.setPullTimeDelayMillsWhenException(1000);
result.setUnitMode(true);
result.setSocksProxyConfig("{}");
result.setLanguage(LanguageCode.JAVA);
result.setDecodeReadBody(true);
result.setDecodeDecompressBody(true);
result.setAccessChannel(AccessChannel.LOCAL);
result.setMqClientApiTimeout(1000 * 3);
result.setEnableStreamRequestType(true);
result.setSendLatencyEnable(true);
result.setEnableHeartbeatChannelEventListener(true);
result.setDetectTimeout(200);
result.setDetectInterval(1000 * 2);
result.setUseHeartbeatV2(false);
result.buildMQClientId();
result.setNamespace("lmq");
return result;
}
}
Loading