[Improve][Connector-V2] Redis support custom key and value #7888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_column") .stringType() .noDefaultValue() .withDescription("key, list, set, zset use value of a specific column"); public static final Option<String> HASH_KEY_COLUMN = Options.key("hash_key_column") .stringType() .noDefaultValue() .withDescription("The column of hash key you want to write to redis"); public static final Option<String> HASH_VALUE_COLUMN = Options.key("hash_value_column") .stringType() .noDefaultValue() .withDescription("The column of hash value you want to write to redis");
|
cc @FuYouJ |
|
1: Please write a new e2e test based on your code to test the configuration of customer key, customer value, hashkey, hashvalue |
@FuYouJ done |
|
Hi @lm-ylj , please follow the guide to open github action on your fork repository. https://github.com/apache/seatunnel/pull/7888/checks?check_run_id=32048740178 |
|
The new features you added are very important. I think you should include more configuration examples in redis.md to help users understand how to use them. |
Hisoka-X
reviewed
Oct 29, 2024
| Options.key("support_custom_key") | ||
| .booleanType() | ||
| .defaultValue(false) | ||
| .withDescription("if true, enables connection recovery"); |
There was a problem hiding this comment.
Suggested change
| .withDescription("if true, enables connection recovery"); | |
| .withDescription("if true, the key can be customized by the field value in the upstream data."); |
Hisoka-X
removed
the
don't merge
Hisoka-X
approved these changes
Oct 29, 2024
hailin0
approved these changes
Oct 29, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
close #7884
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.