-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improve][Connector-V2] Redis support custom key and value #7888
Merged
Merged
Changes from 31 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
d7eb718
fix redis hash error
lm-ylj 9b98e6d
Merge branch 'apache:dev' into dev
lm-ylj 2df5ec2
Update RedisDataType.java
lm-ylj cae040c
[Feature][Connector-Redis]Support redis sink to write custom key and …
lm-ylj 0d78d04
[Feature][Connector-Redis]Support redis sink to write custom key and …
lm-ylj 459e7c4
public static final Option<String> VALUE_COLUMN = Opt…
lm-ylj 3823a52
[Feature][Connector-Redis]Support redis sink to write custom key and …
lm-ylj e3b42db
[Feature][Connector-Redis]Support redis sink to write custom key and …
lm-ylj 45fcbcf
[Feature][Connector-Redis]Support redis sink to write custom key and …
lm-ylj 0195fef
[Feature][Connector-Redis]Support redis sink to write custom key and …
lm-ylj fcacf4f
[Feature][Connector-Redis]Support redis sink to write custom key and …
lm-ylj 80c8eb0
[Improve][Connector-Redis] Redis support custom key and value
lm-ylj 80dab89
add redis e2e test case
lm-ylj cec403c
add redis e2e test case
lm-ylj b6adcc8
add redis e2e test case
lm-ylj 31553dc
add redis e2e test case
lm-ylj b1e80ca
add redis e2e test case
lm-ylj cd991eb
add redis e2e test case
lm-ylj e5e2781
add redis e2e test case
lm-ylj f4cca6e
Merge branch 'apache:dev' into dev
lm-ylj 6cc8c26
modify code format
lm-ylj 23238ac
update docs
lm-ylj 3cf3200
update docs
lm-ylj 04c07ef
Merge branch 'apache:dev' into dev
lm-ylj e672b78
add cos as checkpoint storage type
lm-ylj 558d3b6
update code
lm-ylj 5f480c9
[Improve][Connector-Redis] Redis support custom key and value
cbb33f9
[Improve][Connector-Redis] Redis support custom key and value
d87241d
[Improve][Connector-Redis] Redis support custom key and value
d5a2871
[Improve][Connector-Redis] Redis support custom key and value
6f3eb09
[Improve][Connector-Redis] Redis support custom key and value
53e2031
[Improve][Connector-Redis] Redis support custom key and value
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -127,6 +127,31 @@ public enum HashKeyParseMode { | |
"batch_size is used to control the size of a batch of data during read and write operations" | ||
+ ",default 10"); | ||
|
||
public static final Option<Boolean> SUPPORT_CUSTOM_KEY = | ||
Options.key("support_custom_key") | ||
.booleanType() | ||
.defaultValue(false) | ||
.withDescription("if true, the key can be customized by the field value in the upstream data."); | ||
|
||
public static final Option<String> VALUE_FIELD = | ||
Options.key("value_field") | ||
.stringType() | ||
.noDefaultValue() | ||
.withDescription( | ||
"The field of value you want to write to redis, support string list set zset"); | ||
|
||
public static final Option<String> HASH_KEY_FIELD = | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please add end-to-end testing for the HASH_KEY_FIELD configuration |
||
Options.key("hash_key_field") | ||
.stringType() | ||
.noDefaultValue() | ||
.withDescription("The field of hash key you want to write to redis"); | ||
|
||
public static final Option<String> HASH_VALUE_FIELD = | ||
Options.key("hash_value_field") | ||
.stringType() | ||
.noDefaultValue() | ||
.withDescription("The field of hash value you want to write to redis"); | ||
|
||
public enum Format { | ||
JSON, | ||
// TEXT will be supported later | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it be better to add end-to-end tests for all types, including string, list, set, and zset?