Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the exception when specifying schema when JDBC connects to Proxy #17611

Merged
merged 4 commits into from
May 19, 2022

Conversation

lanchengx
Copy link
Contributor

@lanchengx lanchengx commented May 12, 2022

Fixes #17203

Changes proposed in this pull request:

  • Remove the judgment that the schema is not used

@lanchengx lanchengx requested a review from RaigorJiang May 12, 2022 10:10
@lanchengx lanchengx added this to the 5.1.2 milestone May 12, 2022
@lanchengx lanchengx closed this May 12, 2022
@lanchengx lanchengx reopened this May 19, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #17611 (42be48b) into master (800fcc8) will increase coverage by 0.00%.
The diff coverage is 25.00%.

@@            Coverage Diff            @@
##             master   #17611   +/-   ##
=========================================
  Coverage     59.13%   59.14%           
  Complexity     2131     2131           
=========================================
  Files          3594     3594           
  Lines         53384    53384           
  Branches       9113     9113           
=========================================
+ Hits          31571    31572    +1     
+ Misses        19142    19140    -2     
- Partials       2671     2672    +1     
Impacted Files Coverage Δ
...nd/text/admin/mysql/MySQLAdminExecutorCreator.java 47.61% <25.00%> (+1.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 800fcc8...42be48b. Read the comment docs.

@RaigorJiang RaigorJiang merged commit 1d13c34 into apache:master May 19, 2022
zhaoguhong added a commit to zhaoguhong/shardingsphere that referenced this pull request May 19, 2022
* master:
  Fix the exception when specifying schema when JDBC connects to Proxy (apache#17611)
  Add ProxyContextRestorer to restore proxy context in test cases (apache#17802)
  Remove redundant blank chars and lines in codes (apache#17799)
  Supports scaling MySQL table which only contains unique index (apache#17786)
  Add unit test for ModShardingAlgorithm check Argument(apache#17695) (apache#17772)
  Move getSchemas method to ShardingSphereDatabase (apache#17798)
  Fix unit tests in proxy-frontend-core affected by other tests (apache#17796)
  Update powered by (apache#17795)
  Add support for more JSR-310 related classes about JDBC Timestamp in IntervalShardingAlgorithm (apache#17754)
  Rename ShardingSphereMetaData to ShardingSphereDatabaseMetaData (apache#17792)
  Rename MetaDataContexts.persistService (apache#17789)
  Move ContextManager.executorEngine (apache#17783)
  Change proxy log print at Docker images, get more information (apache#17788)
  fix datasource closed exception for db-discovery (apache#17774)
  Add lock method for schema in lock manager (apache#17787)
  Refactor MetaDataChangedWatcher (apache#17781)
  Refactor PipelineTableMetaDataLoader and fix typo in PipelineTableMetaData (apache#17778)
  Rename DatabaseRulesBuilder (apache#17780)

# Conflicts:
#	shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-core/src/test/java/org/apache/shardingsphere/encrypt/merge/dql/EncryptAlgorithmMetaDataTest.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MySQL create database succeed, but can't use it at JDBC
4 participants