Add unit test for ModShardingAlgorithm check Argument(#17695) #17772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strongduanmu
requested changes
May 18, 2022
Codecov Report
@@ Coverage Diff @@
## master #17772 +/- ##
============================================
+ Coverage 59.02% 59.14% +0.11%
- Complexity 2128 2131 +3
============================================
Files 3593 3594 +1
Lines 53378 53384 +6
Branches 9116 9113 -3
============================================
+ Hits 31506 31572 +66
+ Misses 19207 19142 -65
- Partials 2665 2670 +5
Continue to review full report at Codecov.
|
|
done |
strongduanmu
approved these changes
May 19, 2022
zhaoguhong
added a commit
to zhaoguhong/shardingsphere
that referenced
this pull request
May 19, 2022
* master: Fix the exception when specifying schema when JDBC connects to Proxy (apache#17611) Add ProxyContextRestorer to restore proxy context in test cases (apache#17802) Remove redundant blank chars and lines in codes (apache#17799) Supports scaling MySQL table which only contains unique index (apache#17786) Add unit test for ModShardingAlgorithm check Argument(apache#17695) (apache#17772) Move getSchemas method to ShardingSphereDatabase (apache#17798) Fix unit tests in proxy-frontend-core affected by other tests (apache#17796) Update powered by (apache#17795) Add support for more JSR-310 related classes about JDBC Timestamp in IntervalShardingAlgorithm (apache#17754) Rename ShardingSphereMetaData to ShardingSphereDatabaseMetaData (apache#17792) Rename MetaDataContexts.persistService (apache#17789) Move ContextManager.executorEngine (apache#17783) Change proxy log print at Docker images, get more information (apache#17788) fix datasource closed exception for db-discovery (apache#17774) Add lock method for schema in lock manager (apache#17787) Refactor MetaDataChangedWatcher (apache#17781) Refactor PipelineTableMetaDataLoader and fix typo in PipelineTableMetaData (apache#17778) Rename DatabaseRulesBuilder (apache#17780) # Conflicts: # shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-core/src/test/java/org/apache/shardingsphere/encrypt/merge/dql/EncryptAlgorithmMetaDataTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17695.
Changes proposed in this pull request:
-Add unit test for ModShardingAlgorithm check Argument