-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GraalVM Reachability Metadata and corresponding nativeTest for Firebird #34307
Draft
linghengqian
wants to merge
2
commits into
apache:master
Choose a base branch
from
linghengqian:firebird
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
linghengqian
force-pushed
the
firebird
branch
16 times, most recently
from
January 12, 2025 14:25
0e2a259
to
ffac483
Compare
linghengqian
commented
Jan 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The interesting thing is that I cannot reproduce the error log of https://github.com/apache/shardingsphere/actions/runs/12734368802/job/35491847525?pr=34307 locally.
Failures (1):
JUnit Jupiter:FirebirdTest:assertShardingInLocalTransactions()
MethodSource [className = 'org.apache.shardingsphere.test.natived.jdbc.databases.FirebirdTest', methodName = 'assertShardingInLocalTransactions', methodParameterTypes = '']
=> java.sql.SQLTransientConnectionException: HikariPool-65 - Connection is not available, request timed out after 30000ms.
com.zaxxer.hikari.pool.HikariPool.createTimeoutException(HikariPool.java:696)
com.zaxxer.hikari.pool.HikariPool.getConnection(HikariPool.java:197)
com.zaxxer.hikari.pool.HikariPool.getConnection(HikariPool.java:162)
com.zaxxer.hikari.HikariDataSource.getConnection(HikariDataSource.java:128)
org.apache.shardingsphere.driver.jdbc.core.connection.DriverDatabaseConnectionManager.createConnection(DriverDatabaseConnectionManager.java:375)
- Maybe there is something I'm not aware of and the connection leak only happens in the Github Actions device.
- update in 2025.01.12: According to the results of https://github.com/apache/shardingsphere/actions/runs/12734759305/job/35492699852?pr=34307 ,
org.apache.shardingsphere.test.natived.jdbc.databases.FirebirdTest
runs fine under normal JVM, but fails under GraalVM Native Image, which is interesting. - update in 2025.01.14: According to the test results of https://github.com/apache/shardingsphere/actions/runs/12768181816/job/35588020566?pr=34307 ,
org.apache.shardingsphere.test.natived.proxy.transactions.base.SeataTest
's NativeTest will cause connection leaks and destroy the unit test of SS JDBC, which is too outrageous. - update in 2025.01.15: First, we need to deal with Split nativeTest modules for JDBC and Proxy #34358 . Otherwise, I won’t know what the missing GraalVM Reachability Meatdata is, and the log will be too messy.
linghengqian
force-pushed
the
firebird
branch
6 times, most recently
from
January 13, 2025 05:56
8747369
to
874d367
Compare
7 tasks
linghengqian
force-pushed
the
firebird
branch
from
January 13, 2025 07:40
874d367
to
c65bd4e
Compare
7 tasks
linghengqian
force-pushed
the
firebird
branch
9 times, most recently
from
January 14, 2025 13:00
8e4bd66
to
397b6da
Compare
linghengqian
force-pushed
the
firebird
branch
from
January 14, 2025 13:47
397b6da
to
fa36d01
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #29052.
Changes proposed in this pull request:
create table if not exists
for Docker Imageghcr.io/fdcastel/firebird:5.0.1
, see Create if not exists FirebirdSQL/firebird#8062ghcr.io/fdcastel/firebird:5.0.1
does not work withDROP TABLE IF EXISTS
, see DROP [IF EXISTS] ... [CORE3863] FirebirdSQL/firebird#4203ghcr.io/fdcastel/firebird:5.0.1
cannot useTRUNCATE TABLE
, see Add TRUNCATE TABLE [CORE2479] FirebirdSQL/firebird#2892Create Database
cannot be executed on the Firebird JDBC driver. Unit testing requires the use oforg.firebirdsql.management.FBManager
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e
.