Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Flaky Test related to ClickHouse in NativeTest under GraalVM Native Image #34333

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

linghengqian
Copy link
Member

For #29052.

Changes proposed in this pull request:

  • Fix the Flaky Test related to ClickHouse in NativeTest under GraalVM Native Image. The current PR was split from Add GraalVM Reachability Metadata and corresponding nativeTest for Firebird #34307 to facilitate review.
  • org.apache.shardingsphere.test.natived.jdbc.databases.ClickHouseTest previously started ClickHouse Server and ClickHouse Keeper at the same time, but never performed a health check on ClickHouse Keeper. This caused this unit test to fail frequently. This PR performs a health check on ClickHouse Keeper through Apache Curator to fix the unstable state of CI.
  • Fix several documentation errors.
  • Fix several historical issues with nativeTest, including the problem that the global ContextManager instance was not closed properly during the unit test lifecycle.

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.
  • I have updated the Release Notes of the current development version. For more details, see Update Release Note

@RaigorJiang RaigorJiang merged commit 3191042 into apache:master Jan 13, 2025
148 checks passed
@linghengqian linghengqian deleted the re-clickhouse branch January 13, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants