Support to bind TLS status as a part of component for service topology. #10522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kezhenxu94
previously approved these changes
Mar 9, 2023
kezhenxu94
previously approved these changes
Mar 10, 2023
|
@kezhenxu94 One left issue caused by Service Mesh analysis. The TLS_MODE is not set by ALS analyzer, which leads to clientComponent is always |
We tried to check, the TLS property seems not to be reported from client side by ALS. |
This reverts commit 3876c6b.
|
TODO @kezhenxu94 @mrproliu We don't query source/target component IDs from CLI. We should fix these(I feel this may be caused by these fields being relatively new added). |
kezhenxu94
approved these changes
Mar 10, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGESlog.By this, the service topology(source/target components) includes the TLS for the service mesh case. The components could be [http, tls], [http, mtls], etc.
@toffentoffen Would you like to try this?