Fix the CSS of Spark 3.5.0 doc's generated tables #492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gengliangwang
changed the title
viirya
approved these changes
Nov 30, 2023
Member
Author
|
@viirya Thanks for the review. I am merging it now and will double-check on the website. |
Member
|
Thank you @gengliangwang |
Member
Author
|
I confirmed that the changes work as expected! |
Member
|
Thanks @gengliangwang for confirming that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After apache/spark#40269, there is no border in the generated tables of Spark doc(for example, sql-ref-ansi-compliance.html) . Currently only the doc of Spark 3.5.0 is affected.
This PR is to apply the changes in apache/spark#44096 on the current Spark 3.5.0 doc by
site/docs/3.5.0/css/custom.csssed -i '' 's/table class="table table-striped"/table/' *.htmlundersite/docs/3.5.0/directory.This should be a safe change. I have verified it on my local env.