[SPARK-46188][Doc] Fix the CSS of Spark doc's generated tables #44096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b19c925.
Member
Author
|
cc @grundprinzip as well |
gengliangwang
commented
Nov 30, 2023
| } | ||
|
|
||
| table th, table td { | ||
| border: 1px solid #cccccc; /* Adds a border to each table header and data cell */ |
Member
Author
There was a problem hiding this comment.
I asked ChatGPT to recover the CSS with doc. It looks good so I keep it.
Member
Author
There was a problem hiding this comment.
The result of the changes are done by myself.
Contributor
There was a problem hiding this comment.
why dropping the striped this is exactly what the bootstrap theme already provides us.
The easier way would be simply to
.table {
border-collapse: collapse;
border: 1px solid #ccc
}
Member
Author
There was a problem hiding this comment.
I tried the striped style but it was not very clear when there is long text ( you can find it in the commit history):
dongjoon-hyun
approved these changes
Nov 30, 2023
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @gengliangwang .
grundprinzip
approved these changes
Nov 30, 2023
viirya
approved these changes
Nov 30, 2023
Member
Author
|
Merging to master |
Member
Author
|
Created backport for 3.5 in #44097 |
This was referenced Nov 30, 2023
gengliangwang
added a commit
to apache/spark-website
that referenced
this pull request
Nov 30, 2023
After apache/spark#40269, there is no border in the generated tables of Spark doc(for example, [sql-ref-ansi-compliance.html](https://spark.apache.org/docs/latest/sql-ref-ansi-compliance.html)) . Currently only the doc of Spark 3.5.0 is affected. This PR is to apply the changes in apache/spark#44096 on the current Spark 3.5.0 doc by 1. change the `site/docs/3.5.0/css/custom.css` 2. Execute `sed -i '' 's/table class="table table-striped"/table/' *.html` under `site/docs/3.5.0/` directory. This should be a safe change. I have verified it on my local env.
asl3
pushed a commit
to asl3/spark
that referenced
this pull request
Dec 5, 2023
### What changes were proposed in this pull request? After apache#40269, there is no border in the generated tables of Spark doc(for example, https://spark.apache.org/docs/latest/sql-ref-ansi-compliance.html) . This PR is to fix it by restoring part of the table style in https://github.com/apache/spark/pull/40269/files#diff-309b964023ca899c9505205f36d3f4d5b36a6487e5c9b2e242204ee06bbc9ce9L26 This PR also unifies all the styles of tables by removing the `class="table table-striped"` in HTML style tables in markdown docs. ### Why are the changes needed? Fix a regression in the table CSS of Spark docs ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Manually build docs and verify. Before changes: <img width="931" alt="image" src="https://github.com/apache/spark/assets/1097932/1eb7abff-65af-4c4c-bbd5-9077f38c1b43"> After changes: <img width="911" alt="image" src="https://github.com/apache/spark/assets/1097932/be77d4c6-1279-43ec-a234-b69ee02e3dc6"> ### Was this patch authored or co-authored using generative AI tooling? Generated-by: ChatGPT 4 Closes apache#44096 from gengliangwang/fixTable. Authored-by: Gengliang Wang <gengliang@apache.org> Signed-off-by: Gengliang Wang <gengliang@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
After #40269, there is no border in the generated tables of Spark doc(for example, https://spark.apache.org/docs/latest/sql-ref-ansi-compliance.html) . This PR is to fix it by restoring part of the table style in https://github.com/apache/spark/pull/40269/files#diff-309b964023ca899c9505205f36d3f4d5b36a6487e5c9b2e242204ee06bbc9ce9L26
This PR also unifies all the styles of tables by removing the
class="table table-striped"in HTML style tables in markdown docs.Why are the changes needed?
Fix a regression in the table CSS of Spark docs
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manually build docs and verify.
Before changes:
After changes:
Was this patch authored or co-authored using generative AI tooling?
Generated-by: ChatGPT 4