Skip to content

Conversation

@KaiXinXiaoLei
Copy link

What changes were proposed in this pull request?

if a stage is failed and attempt to start again, DAG visualization does not render correctly for this stage. Because in spark-dag-viz.js, the link of stage is ("#stage-" + stageId + "-" + attemptId), and the value of attemptId is 0 . So I think the attemptId of stage sholike this: stageopening spark web, the attemptId of stage should be transfer to web, and make the link of ("#stage-" + stageId + "-" + attemptId) is correct.

How was this patch tested?

Please test as fellow. Run spark app, and kill executor to make stage reSubmitted. Then check DAG visualization in web.

@SparkQA
Copy link

SparkQA commented Mar 30, 2016

Test build #54506 has finished for PR 12059 at commit 71bebd6.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@holdenk
Copy link
Contributor

holdenk commented Apr 19, 2016

My guess is that the PySpark test failure was unrelated, jenkins retest this please.

@holdenk
Copy link
Contributor

holdenk commented Apr 19, 2016

cc @ajbozarth who has been working on a number of Spark UI changes lately.

@SparkQA
Copy link

SparkQA commented Apr 19, 2016

Test build #56178 has finished for PR 12059 at commit 71bebd6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@KaiXinXiaoLei
Copy link
Author

@ajbozarth help me check, thanks

@ajbozarth
Copy link
Member

I'll take a look this afternoon

@ajbozarth
Copy link
Member

I'll have to take a look tomorrow, I've been blocked by local env issues all afternoon

@ajbozarth
Copy link
Member

I can't seem to recreate the problem you're fixing so my input is limited. Just looking over your code though I don't see any glaring issues. Sorry I can't be more help.

@SparkQA
Copy link

SparkQA commented Jul 26, 2016

Test build #62866 has finished for PR 12059 at commit 71bebd6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@ajbozarth
Copy link
Member

@KaiXinXiaoLei this pr has been stale for a long time, is this still an issue you wan to fix? If not could you close it?

@srowen srowen mentioned this pull request Mar 22, 2017
@asfgit asfgit closed this in b70c03a Mar 23, 2017
zifeif2 pushed a commit to zifeif2/spark that referenced this pull request Nov 22, 2025
Closes apache#16819
Closes apache#13467
Closes apache#16083
Closes apache#17135
Closes apache#8785
Closes apache#16278
Closes apache#16997
Closes apache#17073
Closes apache#17220

Added:
Closes apache#12059
Closes apache#12524
Closes apache#12888
Closes apache#16061

Author: Sean Owen <sowen@cloudera.com>

Closes apache#17386 from srowen/StalePRs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants