[SPARK-14772][ML,PySpark]Python ML Params.copy treats uid, paramMaps … #12888
Conversation
…differently than Scala
| return self._defaultParamMap[param] | ||
|
|
||
| @since("1.4.0") | ||
| def extractParamMap(self, extra=None): |
There was a problem hiding this comment.
Please document this new param
|
Thanks for tackling this issue :) For a better understanding - is there a reason why adding a flag for this behaviour instead of just changing it (since it is a bug) - do we expect people to want to explicitly copy the default param map in this way? |
|
Also it would be good to have tests to ensure the change has the desired impact. |
|
@holdenk, I'm checking with @jkbradley about "respect the difference between defaultParamMap and paramMap" in the requirement. The new input parameter is optional and will not impact the user not want to copy default param. : ) |
|
ok with test |
|
Can one of the admins verify this patch? |
|
So to trigger the test we will need one of the committers - e.g. @davies is one of the more active Python committers (although he has been busy lately) so we can also check with @MLnick . It would also be nice if you could document the param (even if we don't expect the user to use it - its useful to have it noted for other developers and so users know not to worry about it). |
|
@hujy Thank you for sending this PR, and apologies for not seeing it earlier. Since the other PR for this JIRA is ready to merge, could you please close this issue? Thanks again! |
Closes apache#16819 Closes apache#13467 Closes apache#16083 Closes apache#17135 Closes apache#8785 Closes apache#16278 Closes apache#16997 Closes apache#17073 Closes apache#17220 Added: Closes apache#12059 Closes apache#12524 Closes apache#12888 Closes apache#16061 Author: Sean Owen <sowen@cloudera.com> Closes apache#17386 from srowen/StalePRs.
4 participants
What changes were proposed in this pull request?
The patch referenced SPARK-14772
After apply this patch, user can choose to just copy the default param map or the param map.
How was this patch tested?
Unit test, test locally.